Skip to content

Commit 777e207

Browse files
authored
refactor: Bump opendal to 0.53 for better metrics (#17788)
Signed-off-by: Xuanwo <[email protected]>
1 parent 2b37a4d commit 777e207

File tree

9 files changed

+283
-153
lines changed

9 files changed

+283
-153
lines changed

Cargo.lock

Lines changed: 71 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,10 +380,10 @@ num-derive = "0.4.2"
380380
num-traits = "0.2.19"
381381
num_cpus = "1.13.1"
382382
object = "0.36.5"
383-
object_store_opendal = { version = "0.49.1" }
383+
object_store_opendal = { version = "0.51.0" }
384384
once_cell = "1.15.0"
385385
openai_api_rust = "0.1"
386-
opendal = { version = "0.51.2", features = [
386+
opendal = { version = "0.53.0", features = [
387387
"layers-fastrace",
388388
"layers-prometheus-client",
389389
"layers-async-backtrace",

src/common/storage/src/metrics.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ use opendal::raw::RpList;
3030
use opendal::raw::RpRead;
3131
use opendal::raw::RpWrite;
3232
use opendal::Buffer;
33+
use opendal::Metadata;
3334
use opendal::Result;
3435

3536
/// StorageMetrics represents the metrics of storage (all bytes metrics are compressed size).
@@ -263,7 +264,7 @@ impl<R: oio::Write> oio::Write for StorageMetricsWrapper<R> {
263264
})
264265
}
265266

266-
async fn close(&mut self) -> Result<()> {
267+
async fn close(&mut self) -> Result<Metadata> {
267268
self.inner.close().await
268269
}
269270

@@ -284,7 +285,7 @@ impl<R: oio::BlockingWrite> oio::BlockingWrite for StorageMetricsWrapper<R> {
284285
})
285286
}
286287

287-
fn close(&mut self) -> Result<()> {
288+
fn close(&mut self) -> Result<Metadata> {
288289
self.inner.close()
289290
}
290291
}

0 commit comments

Comments
 (0)