Skip to content

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Dec 2, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Unify the automatic compaction logic across INSERT and other mutation operations (including MERGE INTO, etc.).
  • Instead of triggering automatic compaction on every write, we now trigger auto-compaction only when the number of imperfect blocks exceeds a configured threshold.
  • The rationale: this approach reduces the overhead and performance impact of frequent compaction, avoids unnecessary compaction when write volume or fragmentation is small, and only performs compaction when accumulated fragmentation justifies it — resulting in more efficient and stable storage maintenance.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@zhyass zhyass marked this pull request as draft December 2, 2025 18:33
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 2, 2025
@zhyass zhyass changed the title chore: Merge the logic that triggers automatic compression upon write chore: combine the logic that triggers automatic compression upon write Dec 2, 2025
@zhyass zhyass added the ci-cloud Build docker image for cloud test label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Docker Image for PR

  • tag: pr-19050-df26056-1764703525

note: this image tag is only available for internal use.

@zhyass zhyass added ci-cloud Build docker image for cloud test ci-benchmark Benchmark: run all test and removed ci-cloud Build docker image for cloud test labels Dec 5, 2025
@zhyass zhyass marked this pull request as ready for review December 5, 2025 03:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Docker Image for PR

  • tag: pr-19050-8506fbb-1764909674

note: this image tag is only available for internal use.

@databendlabs databendlabs deleted a comment from github-actions bot Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant