Skip to content

Commit 5873500

Browse files
authored
fix(ics-23): Auto-derive serde::Serialize for CommitmentPrefix (informalsystems#1230)
* Auto-derive serde::Serialize for CommitmentPrefix * Add changelog entry
1 parent 86a0ee0 commit 5873500

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- [ics23] Auto-derive `serde::Serialize` for `CommitmentPrefix`.
2+
([\#1229](https://github.com/cosmos/ibc-rs/issues/1229))

ibc-core/ics23-commitment/types/src/commitment.rs

+1-11
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ impl<'a> TryFrom<&'a CommitmentProofBytes> for MerkleProof {
141141
feature = "borsh",
142142
derive(borsh::BorshSerialize, borsh::BorshDeserialize)
143143
)]
144-
#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
144+
#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
145145
#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
146146
#[derive(Clone, PartialEq, Eq, Hash)]
147147
pub struct CommitmentPrefix {
@@ -183,13 +183,3 @@ impl fmt::Debug for CommitmentPrefix {
183183
}
184184
}
185185
}
186-
187-
#[cfg(feature = "serde")]
188-
impl serde::Serialize for CommitmentPrefix {
189-
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
190-
where
191-
S: serde::Serializer,
192-
{
193-
format!("{self:?}").serialize(serializer)
194-
}
195-
}

0 commit comments

Comments
 (0)