tests: fix to check if staticcall is successful

bluele · bluele · commit 86e5a24bf94d · 2024-11-20T17:02:42.000+09:00
Signed-off-by: Jun Kimura &lt;jun.kimura@datachain.jp&gt;
diff --git a/test/LCPClientTest.t.sol b/test/LCPClientTest.t.sol
@@ -135,6 +135,7 @@ contract LCPClientTest is BasicTest {
                     (bool success, bytes memory ret) = address(lc).staticcall(
                         abi.encodeWithSelector(LCPClientBase.updateClient.selector, clientId, message)
                     );
+                    require(success, "failed to update duplicated client");
                     heights = abi.decode(ret, (Height.Data[]));
                     require(heights.length == 0, "heights length must be 0");
                 }

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ contract LCPClientTest is BasicTest {`
`135`	`135`	`(bool success, bytes memory ret) = address(lc).staticcall(`
`136`	`136`	`abi.encodeWithSelector(LCPClientBase.updateClient.selector, clientId, message)`
`137`	`137`	`);`
	`138`	`+ require(success, "failed to update duplicated client");`
`138`	`139`	`heights = abi.decode(ret, (Height.Data[]));`
`139`	`140`	`require(heights.length == 0, "heights length must be 0");`
`140`	`141`	`}`