Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit 3c18507

Browse files
authored
Merge pull request #554 from nicolasaldecoa/hotfix/diffs-are-equiv-jsons
Hotfix: Correct early return in diffs_are_equiv_jsons not including the set object
2 parents ce52e8b + d8a072f commit 3c18507

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

data_diff/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ def _jsons_equiv(a: str, b: str):
155155

156156

157157
def diffs_are_equiv_jsons(diff: list, json_cols: dict):
158+
overriden_diff_cols = set()
158159
if (len(diff) != 2) or ({diff[0][0], diff[1][0]} != {'+', '-'}):
159-
return False
160+
return False, overriden_diff_cols
160161
match = True
161-
overriden_diff_cols = set()
162162
for i, (col_a, col_b) in enumerate(safezip(diff[0][1][1:], diff[1][1][1:])): # index 0 is extra_columns first elem
163163
# we only attempt to parse columns of JSONType, but we still need to check if non-json columns don't match
164164
match = col_a == col_b

0 commit comments

Comments
 (0)