Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit b2549ea

Browse files
authored
Merge pull request #147 from datafold/smallfix_jul4
Fix tests for PRs from contributors who don't have access to 'secrets'.
2 parents d0ba8a5 + ba46cd0 commit b2549ea

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/common.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@
77
import logging
88
import subprocess
99

10+
# We write 'or None' because Github sometimes creates empty env vars for secrets
1011
TEST_MYSQL_CONN_STRING: str = "mysql://mysql:Password1@localhost/mysql"
1112
TEST_POSTGRESQL_CONN_STRING: str = "postgresql://postgres:Password1@localhost/postgres"
12-
TEST_SNOWFLAKE_CONN_STRING: str = os.environ.get("DATADIFF_SNOWFLAKE_URI", None)
13-
TEST_PRESTO_CONN_STRING: str = os.environ.get("DATADIFF_PRESTO_URI", None)
13+
TEST_SNOWFLAKE_CONN_STRING: str = os.environ.get("DATADIFF_SNOWFLAKE_URI") or None
14+
TEST_PRESTO_CONN_STRING: str = os.environ.get("DATADIFF_PRESTO_URI") or None
1415
TEST_BIGQUERY_CONN_STRING: str = None
1516
TEST_REDSHIFT_CONN_STRING: str = None
1617
TEST_ORACLE_CONN_STRING: str = None

0 commit comments

Comments
 (0)