From 292e524fe9eaf306d6084411e5b97b0bf5c32e54 Mon Sep 17 00:00:00 2001 From: Shirshanka Das Date: Tue, 21 Jan 2025 10:48:12 -0800 Subject: [PATCH] remove commented code, fix smoke test --- .../linkedin/datahub/graphql/GmsGraphQLEngine.java | 11 ----------- .../mappers/DataProcessInstanceMapper.java | 4 ---- smoke-test/tests/cypress/data.json | 13 ------------- .../test_data_process_instance.py | 7 ------- 4 files changed, 35 deletions(-) diff --git a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java index 0b919032d6e766..2c5e841322f45f 100644 --- a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java +++ b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java @@ -3108,17 +3108,6 @@ private void configureDataProcessInstanceResolvers(final RuntimeWiring.Builder b ? dataProcessInstance.getDataPlatformInstance().getUrn() : null; })) - // .dataFetcher( - // "platform", - // new LoadableTypeResolver<>( - // dataPlatformType, - // (env) -> { - // final DataProcessInstance dataProcessInstance = - // env.getSource(); - // return dataProcessInstance.getPlatform() != null - // ? dataProcessInstance.getPlatform().getUrn() - // : null; - // })) .dataFetcher("parentContainers", new ParentContainersResolver(entityClient)) .dataFetcher( "container", diff --git a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java index d4454d2cf297af..d721f5a5fb522d 100644 --- a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java +++ b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java @@ -79,10 +79,6 @@ public DataProcessInstance apply( DataPlatformInstance dataPlatformInstance = new DataPlatformInstance(dataMap); dataProcessInstance.setDataPlatformInstance( DataPlatformInstanceAspectMapper.map(context, dataPlatformInstance)); - // DataPlatform dataPlatform = new DataPlatform(); - // dataPlatform.setUrn(dataPlatformInstance.getPlatform().toString()); - // dataPlatform.setType(EntityType.DATA_PLATFORM); - // dataProcessInstance.setPlatform(dataPlatform); }); mappingHelper.mapToResult( SUB_TYPES_ASPECT_NAME, diff --git a/smoke-test/tests/cypress/data.json b/smoke-test/tests/cypress/data.json index c44bcafb55a1ce..ce61f7c83a0389 100644 --- a/smoke-test/tests/cypress/data.json +++ b/smoke-test/tests/cypress/data.json @@ -1798,19 +1798,6 @@ }, "systemMetadata": null }, - { - "auditHeader": null, - "entityType": "dataProcessInstance", - "entityUrn": "urn:li:dataProcessInstance:c39d6e424c70a1b3e8982535c68b5b5888", - "entityKeyAspect": null, - "changeType": "UPSERT", - "aspectName": "dataPlatformInstance", - "aspect": { - "json": { - "platform": "urn:li:dataPlatform:airflow" - } - } - }, { "auditHeader": null, "proposedSnapshot": { diff --git a/smoke-test/tests/data_process_instance/test_data_process_instance.py b/smoke-test/tests/data_process_instance/test_data_process_instance.py index bad945f878562b..c0d2c62ba404a9 100644 --- a/smoke-test/tests/data_process_instance/test_data_process_instance.py +++ b/smoke-test/tests/data_process_instance/test_data_process_instance.py @@ -210,13 +210,6 @@ def test_search_dpi(auth_session, ingest_cleanup_data): name } } - platform { - urn - name - properties { - type - } - } subTypes { typeNames }