Skip to content

Commit 7a3bdf5

Browse files
committed
[wip] fix linting
1 parent c4999be commit 7a3bdf5

File tree

3 files changed

+27
-411
lines changed

3 files changed

+27
-411
lines changed

metadata-ingestion/examples/ml/create_ml.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,10 @@ def generate_pipeline(
259259
)
260260

261261
data_process_instance.subtype = "ML Training Run"
262-
data_process_instance.inlets = [DatasetUrn.from_string(input_dataset.urn)]
262+
if input_dataset.urn is not None:
263+
data_process_instance.inlets = [
264+
DatasetUrn.from_string(input_dataset.urn)
265+
]
263266

264267
output_dataset = Dataset(
265268
id=f"passenger_forecast_24_12_0{i}",
@@ -270,8 +273,10 @@ def generate_pipeline(
270273
schema=None,
271274
)
272275
yield from output_dataset.generate_mcp()
273-
274-
data_process_instance.outlets = [DatasetUrn.from_string(output_dataset.urn)]
276+
if output_dataset.urn is not None:
277+
data_process_instance.outlets = [
278+
DatasetUrn.from_string(output_dataset.urn)
279+
]
275280

276281
# Training metrics and hyperparameters
277282
training_metrics = [
@@ -335,22 +340,25 @@ def generate_pipeline(
335340
)
336341

337342
# Generate start and end events
338-
start_time_millis = run_dict[run_id]["start_time"]
339-
duration_minutes = run_dict[run_id]["duration"]
340-
end_time_millis = start_time_millis + duration_minutes * 60000
343+
start_time_millis = int(run_dict[run_id]["start_time"])
344+
duration_minutes = int(run_dict[run_id]["duration"])
345+
end_time_millis = start_time_millis + (duration_minutes * 60000)
341346
result = run_dict[run_id]["result"]
347+
if not isinstance(result, InstanceRunResult):
348+
raise TypeError(f"Expected InstanceRunResult, got {type(result)}")
349+
342350
result_type = (
343351
"SUCCESS" if result == InstanceRunResult.SUCCESS else "FAILURE"
344352
)
345353

346354
yield from data_process_instance.start_event_mcp(
347-
start_timestamp_millis=start_time_millis
355+
start_timestamp_millis=int(start_time_millis)
348356
)
349357
yield from data_process_instance.end_event_mcp(
350-
end_timestamp_millis=end_time_millis,
358+
end_timestamp_millis=int(end_time_millis),
351359
result=result,
352360
result_type=result_type,
353-
start_timestamp_millis=start_time_millis,
361+
start_timestamp_millis=int(start_time_millis),
354362
)
355363

356364
# Model

0 commit comments

Comments
 (0)