continue to chug away at cypress tests - everything except query_tab?

datahub-project · Jan 29, 2025 · 80fac07 · 80fac07
1 parent e839a58
commit 80fac07
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 10 deletions.
diff --git a/datahub-web-react/src/app/homeV2/layout/NavLinksMenu.tsx b/datahub-web-react/src/app/homeV2/layout/NavLinksMenu.tsx
@@ -236,7 +236,7 @@ export function NavLinksMenu(props: Props) {
     ];
 
     return (
-        <LinksWrapper areLinksHidden={areLinksHidden}>
+        <LinksWrapper areLinksHidden={areLinksHidden} data-testid="nav-menu-links">
             {menuItems.map((menuItem) => {
                 // If menu is hidden, don't show it
                 if (menuItem.isHidden) return null;

diff --git a/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx b/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx
@@ -70,7 +70,7 @@ export default function NavBarMenu({ menu, selectedKey, isCollapsed, iconSize, s
     };
 
     return (
-        <StyledMenu selectedKeys={selectedKey ? [selectedKey] : []} style={style}>
+        <StyledMenu selectedKeys={selectedKey ? [selectedKey] : []} style={style} data-testid="nav-menu-links">
             {menu.items.map((item) => renderMenuItem(item))}
         </StyledMenu>
     );

diff --git a/smoke-test/tests/cypress/cypress/e2e/glossaryV2/v2_glossaryTerm.js b/smoke-test/tests/cypress/cypress/e2e/glossaryV2/v2_glossaryTerm.js
@@ -57,6 +57,7 @@ describe("glossaryTerm", () => {
     cy.loginWithCredentials();
     cy.skipIntroducePage();
     nevigateGlossaryPage();
+    cy.wait(1000); // adding waits because UI flickers with new UI and causes cypress to miss things
   });
 
   it("can search related entities by query", () => {

diff --git a/smoke-test/tests/cypress/cypress/e2e/homeV2/v2_home.js b/smoke-test/tests/cypress/cypress/e2e/homeV2/v2_home.js
@@ -9,6 +9,6 @@ describe("home", () => {
     cy.visit("/");
     cy.get('[xmlns="http://www.w3.org/2000/svg"]').should("exist");
     cy.get('[data-testid="home-page-content-container"').should("exist");
-    cy.get('[class^="NavLinksMenu__LinksWrapper').should("exist");
+    cy.get('[data-testid="nav-menu-links"').should("exist");
   });
 });
diff --git a/smoke-test/tests/cypress/cypress/e2e/mutations/add_users.js b/smoke-test/tests/cypress/cypress/e2e/mutations/add_users.js
@@ -33,7 +33,7 @@ describe("add_user", () => {
         cy.visit(inviteLink);
         const { name, email } = tryToSignUp();
         registeredEmail = email;
-        cy.waitTextVisible("Welcome to DataHub");
+        cy.waitTextVisible("Welcome back");
         cy.hideOnboardingTour();
         cy.waitTextVisible(name);
       })

diff --git a/smoke-test/tests/cypress/cypress/e2e/mutations/manage_ingestion_secret_privilege.js b/smoke-test/tests/cypress/cypress/e2e/mutations/manage_ingestion_secret_privilege.js
@@ -147,7 +147,7 @@ describe("Manage Ingestion and Secret Privileges", () => {
       cy.visit(inviteLink);
       const { name, email } = tryToSignUp();
       registeredEmail = email;
-      cy.waitTextVisible("Welcome to DataHub");
+      cy.waitTextVisible("Welcome back");
       cy.hideOnboardingTour();
       cy.waitTextVisible(name);
     });
@@ -164,7 +164,7 @@ describe("Manage Ingestion and Secret Privileges", () => {
     cy.clearCookies();
     cy.clearLocalStorage();
     signIn();
-    cy.waitTextVisible("Welcome to DataHub");
+    cy.waitTextVisible("Welcome back");
     cy.hideOnboardingTour();
     cy.waitTextVisible(name);
     cy.clickOptionWithText("Ingestion");
@@ -185,7 +185,7 @@ describe("Manage Ingestion and Secret Privileges", () => {
     editPolicy(platform_policy_name, "Secret", "Manage Secrets");
     cy.logout();
     signIn();
-    cy.waitTextVisible("Welcome to DataHub");
+    cy.waitTextVisible("Welcome back");
     cy.hideOnboardingTour();
     cy.waitTextVisible(name);
     cy.clickOptionWithText("Ingestion");

diff --git a/smoke-test/tests/cypress/cypress/e2e/settings/managing_groups.js b/smoke-test/tests/cypress/cypress/e2e/settings/managing_groups.js
@@ -22,7 +22,7 @@ describe("create and manage group", () => {
       cy.mouseover("#title").click();
       cy.waitTextVisible("Other").click();
       cy.get("[type=submit]").click();
-      cy.waitTextVisible("Welcome to DataHub");
+      cy.waitTextVisible("Welcome back");
       cy.hideOnboardingTour();
       cy.waitTextVisible(username);
     });

diff --git a/smoke-test/tests/cypress/cypress/support/commands.js b/smoke-test/tests/cypress/cypress/support/commands.js
@@ -448,7 +448,7 @@ Cypress.Commands.add("createUser", (name, password, email) => {
     cy.mouseover("#title").click();
     cy.waitTextVisible("Other").click();
     cy.get("[type=submit]").click();
-    cy.waitTextVisible("Welcome to DataHub");
+    cy.waitTextVisible("Welcome back");
     cy.hideOnboardingTour();
     cy.waitTextVisible(name);
     cy.logout();

diff --git a/smoke-test/tests/cypress/incidents_test.json b/smoke-test/tests/cypress/incidents_test.json
@@ -143,7 +143,7 @@
   {
     "auditHeader": null,
     "entityType": "incident",
-    "entityUrn": "urn:li:incident:test",
+    "entityUrn": "urn:li:incident:test2",
     "changeType": "UPSERT",
     "aspectName": "incidentInfo",
     "aspect": {