remove link

datahub-project · Feb 4, 2025 · 97acaac · 97acaac
1 parent d63cb09
commit 97acaac
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 12 deletions.
diff --git a/datahub-web-react/src/app/entityV2/shared/EntitySearchInput/EntitySearchInputResultV2.tsx b/datahub-web-react/src/app/entityV2/shared/EntitySearchInput/EntitySearchInputResultV2.tsx
@@ -54,6 +54,7 @@ export default function EntitySearchInputResultV2({ entity }: Props) {
                     }
                     contentRef={contentRef}
                     isContentTruncated={isContentTruncated}
+                    linksDisabled
                 />
             </TextWrapper>
         </Wrapper>

diff --git a/datahub-web-react/src/app/previewV2/BrowsePaths.tsx b/datahub-web-react/src/app/previewV2/BrowsePaths.tsx
@@ -64,17 +64,25 @@ interface Props {
     browsePaths?: Maybe<BrowsePathV2> | undefined;
     contentRef: React.RefObject<HTMLDivElement>;
     isContentTruncated: boolean;
+    linksDisabled?: boolean;
 }
 
-const BrowsePathSection = ({ path }: { path: BrowsePathEntry }) => {
+const BrowsePathSection = ({ path, linksDisabled }: { path: BrowsePathEntry } & Pick<Props, 'linksDisabled'>) => {
     if (!path.entity) {
         return <PlatFormTitle>{path.name}</PlatFormTitle>;
     }
-    return <ContextPathEntityLink key={path?.entity?.urn} entity={path?.entity} style={{ fontSize: '12px' }} />;
+    return (
+        <ContextPathEntityLink
+            key={path?.entity?.urn}
+            entity={path?.entity}
+            style={{ fontSize: '12px' }}
+            linkDisabled={linksDisabled}
+        />
+    );
 };
 
 function BrowsePaths(props: Props) {
-    const { previewType, browsePaths, contentRef, isContentTruncated } = props;
+    const { previewType, browsePaths, contentRef, isContentTruncated, linksDisabled } = props;
 
     const parentPath = browsePaths?.path?.[0];
     const remainingParentPaths = browsePaths?.path && browsePaths.path.slice(1, browsePaths.path.length);
@@ -91,15 +99,15 @@ function BrowsePaths(props: Props) {
                 <ParentNodesWrapper ref={contentRef}>
                     {parentPath && (
                         <PlatformText>
-                            <BrowsePathSection path={parentPath} />
+                            <BrowsePathSection path={parentPath} linksDisabled={linksDisabled} />
                             {remainingParentPaths && remainingParentPaths?.length > 0 && <ContextPathSeparator />}
                         </PlatformText>
                     )}
                     {remainingParentPaths &&
                         remainingParentPaths.map((container, index) => {
                             return (
                                 <PlatformText>
-                                    <BrowsePathSection path={container} />
+                                    <BrowsePathSection path={container} linksDisabled={linksDisabled} />
                                     {index < remainingParentPaths.length - 1 && <ContextPathSeparator />}
                                 </PlatformText>
                             );

diff --git a/datahub-web-react/src/app/previewV2/ContextPath.tsx b/datahub-web-react/src/app/previewV2/ContextPath.tsx
@@ -94,6 +94,7 @@ interface Props {
     browsePaths?: Maybe<BrowsePathV2> | undefined;
     contentRef: React.RefObject<HTMLDivElement>;
     isContentTruncated?: boolean;
+    linksDisabled?: boolean;
 }
 
 function ContextPath(props: Props) {
@@ -108,6 +109,7 @@ function ContextPath(props: Props) {
         isCompactView,
         contentRef,
         isContentTruncated = false,
+        linksDisabled,
     } = props;
 
     const entityRegistry = useEntityRegistryV2();
@@ -146,9 +148,10 @@ function ContextPath(props: Props) {
                     previewType={previewType}
                     contentRef={contentRef}
                     isContentTruncated={isContentTruncated}
+                    linksDisabled={linksDisabled}
                 />
             ) : (
-                <ParentEntities parentEntities={parentEntities || []} numVisible={3} />
+                <ParentEntities parentEntities={parentEntities || []} numVisible={3} linksDisabled={linksDisabled} />
             )}
         </PlatformContentWrapper>
     );

diff --git a/datahub-web-react/src/app/previewV2/ContextPathEntityLink.tsx b/datahub-web-react/src/app/previewV2/ContextPathEntityLink.tsx
@@ -28,7 +28,7 @@ const ContainerText = styled.span`
     max-width: 150px; // TODO: Remove in favor of smart truncation
 `;
 
-const StyledLink = styled(Link)`
+const StyledLink = styled(Link)<{ $disabled?: boolean }>`
     white-space: nowrap;
     border-radius: 4px;
     overflow: hidden;
@@ -44,21 +44,22 @@ const StyledLink = styled(Link)`
     }
 
     :hover {
-        color: ${colors.violet[500]};
+        color: ${({ $disabled }) => ($disabled ? REDESIGN_COLORS.LINK_GREY : colors.violet[500])};
 
         && svg {
-            color: ${colors.violet[500]};
+            color: ${({ $disabled }) => ($disabled ? REDESIGN_COLORS.LINK_GREY : colors.violet[500])};
         }
     }
 `;
 
 interface Props {
     entity: Maybe<Entity>;
+    linkDisabled?: boolean;
     style?: React.CSSProperties;
 }
 
 function ContextPathEntityLink(props: Props) {
-    const { entity, style } = props;
+    const { entity, linkDisabled, style } = props;
     const entityRegistry = useEntityRegistry();
     const linkProps = useEmbeddedProfileLinkProps();
 
@@ -69,7 +70,12 @@ function ContextPathEntityLink(props: Props) {
 
     return (
         <Path style={style}>
-            <StyledLink to={containerUrl} data-testid="container" {...linkProps}>
+            <StyledLink
+                to={linkDisabled ? null : containerUrl}
+                data-testid="container"
+                $disabled={linkDisabled}
+                {...linkProps}
+            >
                 <ContextPathEntityIcon entity={entity} />
                 <ContainerText title={containerName}>{containerName}</ContainerText>
             </StyledLink>

diff --git a/datahub-web-react/src/app/searchV2/filters/ParentEntities.tsx b/datahub-web-react/src/app/searchV2/filters/ParentEntities.tsx
@@ -28,9 +28,10 @@ const DEFAULT_NUM_VISIBLE = 2;
 interface Props {
     parentEntities: Entity[];
     numVisible?: number;
+    linksDisabled?: boolean; // don't allow links to parent entities
 }
 
-export default function ParentEntities({ parentEntities, numVisible = DEFAULT_NUM_VISIBLE }: Props) {
+export default function ParentEntities({ parentEntities, numVisible = DEFAULT_NUM_VISIBLE, linksDisabled }: Props) {
     const entityRegistry = useEntityRegistry();
 
     // parent nodes/domains are returned with direct parent first
@@ -72,6 +73,7 @@ export default function ParentEntities({ parentEntities, numVisible = DEFAULT_NU
                             <ContextPathEntityLink
                                 key={parentEntity.urn}
                                 entity={parentEntity}
+                                linkDisabled={linksDisabled}
                                 style={{ fontSize: '12px' }}
                             />
                             {index !== visibleNodes.length - 1 && <ContextPathSeparator />}