feat(actions): add DomainNameResolver for human-friendly domain names (#14355)

Co-authored-by: Claude <[email protected]>

Author: 2 people

datahub-actions/src/datahub_actions/utils/name_resolver.py

@@ -9,6 +9,7 @@
     CorpUserInfoClass,
     DashboardInfoClass,
     DatasetPropertiesClass,
+    DomainPropertiesClass,
     GlossaryTermInfoClass,
     SubTypesClass,
     TagPropertiesClass,
@@ -238,6 +239,21 @@ def get_entity_name(
         return super().get_entity_name(entity_urn, datahub_graph)
 
 
+class DomainNameResolver(DefaultNameResolver):
+    def get_entity_name(
+        self, entity_urn: Urn, datahub_graph: Optional[DataHubGraph]
+    ) -> str:
+        if datahub_graph:
+            domain_properties: Optional[DomainPropertiesClass] = (
+                datahub_graph.get_aspect(str(entity_urn), DomainPropertiesClass)
+            )
+            if domain_properties and domain_properties.name:
+                return domain_properties.name
+
+        # fall-through to default
+        return super().get_entity_name(entity_urn, datahub_graph)
+
+
 class NameResolverRegistry:
     def __init__(self):
         self.registry = {
@@ -250,6 +266,7 @@ def __init__(self):
             "container": ContainerNameResolver(),
             "dataJob": DataJobNameResolver(),
             "dataFlow": DataFlowNameResolver(),
+            "domain": DomainNameResolver(),
         }
         self.default_resolver = DefaultNameResolver()
 

datahub-actions/tests/unit/utils/test_name_resolver.py

@@ -0,0 +1,49 @@
+# Copyright 2021 Acryl Data, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from unittest.mock import Mock
+
+from datahub.metadata.schema_classes import DomainPropertiesClass
+from datahub.utilities.urns.urn import Urn
+from datahub_actions.utils.name_resolver import DomainNameResolver
+
+
+def test_domain_name_resolver_without_graph():
+    # Test DomainNameResolver fallback behavior when DataHubGraph is None
+    resolver = DomainNameResolver()
+    domain_urn = Urn.from_string("urn:li:domain:marketing-domain")
+    entity_name = resolver.get_entity_name(domain_urn, None)
+    assert entity_name == "marketing-domain"
+
+
+def test_domain_name_resolver_with_graph():
+    resolver = DomainNameResolver()
+    domain_urn = Urn.from_string("urn:li:domain:marketing-domain")
+    mock_graph = Mock()
+
+    # Test scenario 1: Graph available but no properties found
+    mock_graph.get_aspect.return_value = None
+    entity_name = resolver.get_entity_name(domain_urn, mock_graph)
+    mock_graph.get_aspect.assert_called_with(str(domain_urn), DomainPropertiesClass)
+    assert entity_name == "marketing-domain"
+
+    # Reset mock for next scenario
+    mock_graph.reset_mock()
+
+    # Test scenario 2: Graph returns properties with name
+    mock_properties = DomainPropertiesClass(name="Marketing Domain")
+    mock_graph.get_aspect.return_value = mock_properties
+    entity_name = resolver.get_entity_name(domain_urn, mock_graph)
+    mock_graph.get_aspect.assert_called_with(str(domain_urn), DomainPropertiesClass)
+    assert entity_name == "Marketing Domain"