From 7627ebcc667c5125c3230b3b6c2f29272347f037 Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Tue, 21 Jan 2025 15:47:57 -0800 Subject: [PATCH] fix(cli): ignore prereleases when suggesting upgrades By fetching the "latest" release, we can ignore prereleases and fetch less data. --- metadata-ingestion/src/datahub/upgrade/upgrade.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/metadata-ingestion/src/datahub/upgrade/upgrade.py b/metadata-ingestion/src/datahub/upgrade/upgrade.py index fb14514588e5f..7872681797d6f 100644 --- a/metadata-ingestion/src/datahub/upgrade/upgrade.py +++ b/metadata-ingestion/src/datahub/upgrade/upgrade.py @@ -93,11 +93,11 @@ async def get_github_stats(): async with aiohttp.ClientSession( headers={"Accept": "application/vnd.github.v3+json"} ) as session: - gh_url = "https://api.github.com/repos/datahub-project/datahub/releases" + gh_url = "https://api.github.com/repos/datahub-project/datahub/releases/latest" async with session.get(gh_url) as gh_response: gh_response_json = await gh_response.json() - latest_server_version = Version(gh_response_json[0].get("tag_name")) - latest_server_date = gh_response_json[0].get("published_at") + latest_server_version = Version(gh_response_json.get("tag_name")) + latest_server_date = gh_response_json.get("published_at") return (latest_server_version, latest_server_date)