Skip to content

Commit b39e4eb

Browse files
committed
Temporary rollback of (part of) commit
8c2c39d since it causes a problem with the JDO TCK, but needs investigation whether the problem is the TCK itself
1 parent 1456602 commit b39e4eb

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

src/main/java/org/datanucleus/store/rdbms/table/ArrayTable.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,11 @@ public boolean isEmbeddedElementPC()
224224
// Serialisation takes precedence over embedding
225225
return false;
226226
}
227-
if (mmd.getArray().elementIsPersistent() && mmd.getArray().isEmbeddedElement())
227+
/*if (mmd.getArray().elementIsPersistent() && mmd.getArray().isEmbeddedElement())
228228
{
229229
// Persistable element, and marked as embedded element
230230
return true;
231-
}
231+
}*/
232232
if (mmd.getElementMetaData() != null && mmd.getElementMetaData().getEmbeddedMetaData() != null)
233233
{
234234
// Embedded metadata provided for element

src/main/java/org/datanucleus/store/rdbms/table/CollectionTable.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,12 @@ public boolean isEmbeddedElementPC()
334334
// Serialisation takes precedence over embedding
335335
return false;
336336
}
337-
if (mmd.getCollection().elementIsPersistent() && mmd.getCollection().isEmbeddedElement())
337+
// TODO Enable this ... see the comment in javadocs for the method
338+
/* if (mmd.getCollection().elementIsPersistent() && mmd.getCollection().isEmbeddedElement())
338339
{
339340
// Persistable element, and marked as embedded element
340341
return true;
341-
}
342+
}*/
342343
if (mmd.getElementMetaData() != null && mmd.getElementMetaData().getEmbeddedMetaData() != null)
343344
{
344345
// Embedded metadata provided for element

src/main/java/org/datanucleus/store/rdbms/table/MapTable.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -479,11 +479,11 @@ public boolean isEmbeddedKeyPC()
479479
// Serialized takes precedence over embedded
480480
return false;
481481
}
482-
if (mmd.getMap().keyIsPersistent() && mmd.getMap().isEmbeddedKey())
482+
/*if (mmd.getMap().keyIsPersistent() && mmd.getMap().isEmbeddedKey())
483483
{
484484
// Persistable key, and marked as embedded key
485485
return true;
486-
}
486+
}*/
487487
if (mmd.getKeyMetaData() != null && mmd.getKeyMetaData().getEmbeddedMetaData() != null)
488488
{
489489
// Embedded metadata provided for key
@@ -549,11 +549,11 @@ public boolean isEmbeddedValuePC()
549549
// Serialized takes precedence over embedded
550550
return false;
551551
}
552-
if (mmd.getMap().valueIsPersistent() && mmd.getMap().isEmbeddedValue())
552+
/*if (mmd.getMap().valueIsPersistent() && mmd.getMap().isEmbeddedValue())
553553
{
554554
// Persistable value, and marked as embedded value
555555
return true;
556-
}
556+
}*/
557557
if (mmd.getValueMetaData() != null && mmd.getValueMetaData().getEmbeddedMetaData() != null)
558558
{
559559
// Embedded metadata provided for value

0 commit comments

Comments
 (0)