Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler inheritance checks #26

Open
antaldaniel opened this issue Jan 21, 2025 · 0 comments
Open

Simpler inheritance checks #26

antaldaniel opened this issue Jan 21, 2025 · 0 comments
Assignees
@antaldaniel
Labels
enhancement New feature or request
Milestone
rOpenSci/CRAN nex...

Comments

@antaldaniel
Copy link
Contributor

Editor comments: The code could be simplified so that reviewers might more easily follow the logic. is_person <- function(p) ifelse (inherits(p, "person"), TRUE, FALSE) in

dataset/R/as_dublincore.R

Line 11 in 7bf85ac

is_person <- function(p) ifelse (inherits(p, "person"), TRUE, FALSE)

@antaldaniel antaldaniel added the enhancement New feature or request label Jan 21, 2025
@antaldaniel antaldaniel self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antaldaniel antaldaniel

Labels
enhancement New feature or request
Projects
None yet
Milestone
rOpenSci/CRAN next release
Development

No branches or pull requests
1 participant
@antaldaniel