code intendation and styling

Author: antaldaniel

R/add_id_statement.R

@@ -21,7 +21,6 @@ add_id_statement <- function(
     wikibase_type = "external-id",
     wikibase_api_url = "https://reprexbase.eu/demowiki/api.php",
     csrf) {
-
   datavalue <- paste0('"', o, '"')
   datavalue
 

R/add_statement.R

@@ -23,7 +23,6 @@ add_statement <- function(
     wikibase_type,
     wikibase_api_url = "https://reprexbase.eu/demowiki/api.php",
     csrf) {
-
   if (wikibase_type == "string") {
     add_item_statement(
       qid = qid, pid = pid, o = o,

R/check_existing_item.R

@@ -22,10 +22,11 @@
 #' @return A data.frame or NULL.
 #' @examples
 #' check_existing_item(
-#'     search_term="Estonian National Museum",
-#'     language = "en",
-#'     wikibase_api_url="https://www.wikidata.org/w/api.php",
-#'     csrf=NULL)
+#'   search_term = "Estonian National Museum",
+#'   language = "en",
+#'   wikibase_api_url = "https://www.wikidata.org/w/api.php",
+#'   csrf = NULL
+#' )
 #' @export
 
 check_existing_item <- function(search_term,
@@ -39,7 +40,6 @@ check_existing_item <- function(search_term,
                                 data_curator = person("Unknown", "Person"),
                                 wikibase_api_url = "https://www.wikidata.org/w/api.php",
                                 csrf = NULL) {
-
   action_timestamp <- action_timestamp_create()
   action_time <- Sys.time()
 
@@ -76,9 +76,11 @@ check_existing_item <- function(search_term,
     this_display$label$value == search_term && this_display$label$language == language
   }
 
-  matching_items <- vapply(1:length(search_response$search),
-                           function(x) search_response$search[[x]]$id,
-                           character(1))
+  matching_items <- vapply(
+    1:length(search_response$search),
+    function(x) search_response$search[[x]]$id,
+    character(1)
+  )
 
 
   exact_match <- vapply(
@@ -87,14 +89,22 @@ check_existing_item <- function(search_term,
     logical(1)
   )
 
-  if (sum(exact_match)>1) {
-    stop("Multiple items [", paste(matching_items, collapse=", "),  "] are matching '", search_term, "' in language='", language, "'." )
+  if (sum(exact_match) > 1) {
+    stop("Multiple items [", paste(matching_items, collapse = ", "), "] are matching '", search_term, "' in language='", language, "'.")
   }
 
-  if (! any(exact_match)) { return(NULL) }
-  if ( is.null(search_response$search[[1]])) { return(NULL) }
-  if ( ! is.list(search_response$search[[1]])) { return(NULL) }
-  if ( is.null(search_response$search[[which(exact_match)]])) { return(NULL)}
+  if (!any(exact_match)) {
+    return(NULL)
+  }
+  if (is.null(search_response$search[[1]])) {
+    return(NULL)
+  }
+  if (!is.list(search_response$search[[1]])) {
+    return(NULL)
+  }
+  if (is.null(search_response$search[[which(exact_match)]])) {
+    return(NULL)
+  }
 
   matching_items[exact_match]
 
@@ -181,7 +191,7 @@ check_existing_item <- function(search_term,
     )
   )
 
-  prefix <- ifelse(wikibase_api_url=="https://www.wikidata.org/w/api.php", "wbi:", "wd:")
+  prefix <- ifelse(wikibase_api_url == "https://www.wikidata.org/w/api.php", "wbi:", "wd:")
   return_ds$rowid <- defined(paste0(prefix, as.character(return_ds$id_on_target)),
     namespace = wikibase_api_url
   )

R/check_existing_property.R

@@ -24,9 +24,10 @@
 #' @examples
 #' # No CSRF needed for Wikidata, but you will need it for Wikibase Suit
 #' check_existing_property(
-#'     search_term="instance of",
-#'     language = "en",
-#'     wikibase_api_url="https://www.wikidata.org/w/api.php")
+#'   search_term = "instance of",
+#'   language = "en",
+#'   wikibase_api_url = "https://www.wikidata.org/w/api.php"
+#' )
 #' @export
 
 check_existing_property <- function(
@@ -39,9 +40,8 @@ check_existing_property <- function(
     action = "create_property",
     log_file_name = NA_character_,
     data_curator = person("Unknown", "Person"),
-    wikibase_api_url="https://www.wikidata.org/w/api.php",
-    csrf=NULL) {
-
+    wikibase_api_url = "https://www.wikidata.org/w/api.php",
+    csrf = NULL) {
   action_timestamp <- action_timestamp_create()
   action_time <- Sys.time()
 
@@ -61,8 +61,9 @@ check_existing_property <- function(
   )
 
   search_response <- httr::content(get_search,
-                                   as = "parsed",
-                                   type = "application/json")
+    as = "parsed",
+    type = "application/json"
+  )
 
   if (!is.null(search_response$error)) {
     stop(paste(search_response$error$code, ": ", search_response$error$info))
@@ -87,24 +88,33 @@ check_existing_property <- function(
     logical(1)
   )
 
-  if (sum(exact_match)>1) {
-    stop("Multiple items [", paste(matching_props, collapse=", "),  "] are matching '", search_term, "' in language='", language, "'." )
+  if (sum(exact_match) > 1) {
+    stop("Multiple items [", paste(matching_props, collapse = ", "), "] are matching '", search_term, "' in language='", language, "'.")
   }
 
-  if (! any(exact_match)) { return(NULL) }
-  if ( is.null(search_response$search[[1]])) { return(NULL) }
-  if ( ! is.list(search_response$search[[1]])) { return(NULL) }
-  if ( is.null(search_response$search[[which(exact_match)]])) { return(NULL)}
+  if (!any(exact_match)) {
+    return(NULL)
+  }
+  if (is.null(search_response$search[[1]])) {
+    return(NULL)
+  }
+  if (!is.list(search_response$search[[1]])) {
+    return(NULL)
+  }
+  if (is.null(search_response$search[[which(exact_match)]])) {
+    return(NULL)
+  }
 
   matching_props[exact_match]
 
   matching_property_data <- search_response$search[[which(exact_match)]]
 
   if (action %in% c("create_property", "copy_property")) {
     datatype <- get_property_definition(matching_property_data$id, "en",
-                                        wikibase_api_url = wikibase_api_url,
-                                        return_type =  "data.frame",
-                                        csrf= csrf)$datatype
+      wikibase_api_url = wikibase_api_url,
+      return_type = "data.frame",
+      csrf = csrf
+    )$datatype
     comment_text <- glue::glue("A property with the label ", search_term, " already exists in this Wikibase.")
   }
 
@@ -187,8 +197,9 @@ check_existing_property <- function(
     )
   )
 
-  prefix <- ifelse(wikibase_api_url=="https://www.wikidata.org/w/api.php",
-                   "wd:", "wbi:")
+  prefix <- ifelse(wikibase_api_url == "https://www.wikidata.org/w/api.php",
+    "wd:", "wbi:"
+  )
 
   return_ds$rowid <- defined(paste0(prefix, as.character(return_ds$id_on_target)),
     namespace = wikibase_api_url

R/copy_wikidata_item.R

@@ -78,7 +78,6 @@ copy_wikidata_item <- function(
     log_file_name = NULL,
     csrf,
     wikibase_session = NULL) {
-
   if (!is.null(wikibase_session)) {
     # For repeated queries you can add your variables directly or in a list
 
@@ -388,7 +387,6 @@ copy_wikidata_item <- function(
       time = action_timestamp,
       logfile = log_file_name
     )
-
   } else if (
     # Case when we have clear message about a label conflict
     any(c(
@@ -552,11 +550,11 @@ copy_wikidata_item <- function(
     namespace = wikibase_api_url
   )
 
-  if(!is.null(log_file_name) && nchar(log_file_name)>0 ) {
+  if (!is.null(log_file_name) && nchar(log_file_name) > 0) {
     write_csv(return_dataframe,
-              file = log_file_name,
-              na = "NA",
-              append = TRUE
+      file = log_file_name,
+      na = "NA",
+      append = TRUE
     )
   }
   return_ds

R/copy_wikidata_property.R

@@ -80,7 +80,6 @@ copy_wikidata_property <- function(
     log_file_name = NULL,
     csrf,
     wikibase_session = NULL) {
-
   if (!is.null(wikibase_session)) {
     # For repeated queries you can add your variables directly or in a list
 
@@ -377,7 +376,6 @@ copy_wikidata_property <- function(
       time = action_timestamp,
       logfile = log_file_name
     )
-
   } else if ("wikibase-validator-label-conflict" %in% unlist(created_property_response$error$messages)) {
     # Unwrap error message and send it to terminal
     message_strings <- unlist(created_property_response$error$messages)
@@ -438,7 +436,6 @@ copy_wikidata_property <- function(
       time = action_timestamp,
       logfile = log_file_name
     )
-
   } else {
     # Return an emptier data.frame if there was some error
 
@@ -539,11 +536,11 @@ copy_wikidata_property <- function(
     namespace = wikibase_api_url
   )
 
-  if(!is.null(log_file_name) && nchar(log_file_name)>0 ) {
+  if (!is.null(log_file_name) && nchar(log_file_name) > 0) {
     write_csv(return_dataframe,
-              file = log_file_name,
-              na = "NA",
-              append = TRUE
+      file = log_file_name,
+      na = "NA",
+      append = TRUE
     )
   }
 

R/get_propety_definition.R

@@ -50,7 +50,6 @@ get_property_definition <- function(
     wikibase_api_url = "https://www.wikidata.org/w/api.php",
     return_type = "JSON",
     csrf = NULL) {
-
   ## Ensure that the pid is a character string starting with P followed by
   ## numbers.
   pid <- as.character(pid)
@@ -226,4 +225,3 @@ get_property_definition <- function(
     )
   }
 }
-

tests/testthat/test-check_existing_item.R

@@ -1,6 +1,10 @@
 test_that("check_existing_item() works", {
-  test <- check_existing_item(search_term="Estonian National Museum",
-                              language = "en")
-  expect_equal(as.character(test$rowid),
-               "wbi:Q1370397")
+  test <- check_existing_item(
+    search_term = "Estonian National Museum",
+    language = "en"
+  )
+  expect_equal(
+    as.character(test$rowid),
+    "wbi:Q1370397"
+  )
 })

tests/testthat/test-check_existing_property.R

@@ -1,10 +1,11 @@
 test_that("check_existing_property() works", {
-  test <- check_existing_property(search_term="instance of", language = "en")
-  expect_equal(as.character(test$rowid),
-               "wd:P31")
-  expect_equal(test$datatype,
-               "wikibase-item")
+  test <- check_existing_property(search_term = "instance of", language = "en")
+  expect_equal(
+    as.character(test$rowid),
+    "wd:P31"
+  )
+  expect_equal(
+    test$datatype,
+    "wikibase-item"
+  )
 })
-
-
-

tests/testthat/test-create_item.R

@@ -24,11 +24,12 @@ agya_wikibase_session <- list(
 )
 
 digital_record_class <- create_item(
-  label="digital record",
-  description="a subclass of the record, a record in the collection of the Andrássy Gyula Foundation.",
+  label = "digital record",
+  description = "a subclass of the record, a record in the collection of the Andrássy Gyula Foundation.",
   language = "en",
-  classification_property = "P137", #subclass of
-  classification_id = "Q584", #record
+  classification_property = "P137", # subclass of
+  classification_id = "Q584", # record
   wikibase_api_url = agya_wikibase_api_url,
   csrf = agya_wikibase_session$csrf,
-  wikibase_session = agya_wikibase_session)
+  wikibase_session = agya_wikibase_session
+)