further assertions for mass copying

Author: antaldaniel

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: wbdataset
 Title: Making Datasets Truly Interoperable and Reusable in R with Wikibase
-Version: 0.1.1014
-Date: 2024-02-18
+Version: 0.1.1015
+Date: 2024-02-19
 Authors@R: 
     c(person(given="Daniel", family="Antal", 
            email= "daniel.antal@dataobservatory.eu", 

R/copy_wikidata_item.R

@@ -460,7 +460,8 @@ copy_wikidata_item <- function(
     time = return_dataframe$time,
     logfile = return_dataframe$logfile,
     dataset_bibentry = dublincore(
-      title = "Wikibase Copy Item Log",
+        title = paste0("Wikibase Copy Item Log (",
+                       strftime(action_time,'%Y-%m-%d %H:%M:%OS0'), ")"),
       description =  description_text,
       creator = data_curator,
       dataset_date = Sys.Date())
@@ -479,6 +480,15 @@ copy_wikidata_items <- function( qid_on_wikidata,
                                  log_path,
                                  csrf) {
 
+  # Ensure that QIDs are used in the loop ----------------------------
+  is_qid <- vapply(qid_on_wikidata, is_qid, logical(1))
+  not_qid <- paste(names(which(!is_qid)), collapse="|")
+
+  assertthat::assert_that(
+    not_qid == "",
+    msg=paste0("Error copy_wikidata_items(): ", not_qid,
+               " does not appear to be a QID."))
+
   returned_list <- lapply(
     qid_on_wikidata, function(x) {
       copy_wikidata_item(

R/copy_wikidata_property.R

@@ -454,7 +454,8 @@ copy_wikidata_property <- function(
     time = return_dataframe$time,
     logfile = return_dataframe$logfile,
     dataset_bibentry = dublincore(
-      title = "Wikibase Copy Property Log",
+      title = paste0("Wikibase Copy Property Log (",
+                     strftime(action_time,'%Y-%m-%d %H:%M:%OS0'), ")"),
       description = description_text,
       creator = data_curator,
       dataset_date = Sys.Date())
@@ -473,6 +474,16 @@ copy_wikidata_properties <- function(
     log_path,
     csrf) {
 
+  # Ensure that PIDs are used in the loop ----------------------------
+  is_pid <- vapply(pid_on_wikidata, is_pid, logical(1))
+  not_pid <- paste(names(which(!is_pid)), collapse="|")
+
+  assertthat::assert_that(
+    not_pid == "",
+    msg=paste0("Error copy_wikidata_properties(): ", not_pid,
+               " does not appear to be a PID."))
+
+
   returned_list <- lapply(
     pid_on_wikidata, function(x) {
       copy_wikidata_property(

R/create_property.R

@@ -152,7 +152,7 @@ create_property <- function(label,
     # Successfully created the property
     message("Successfully created item ", created_property_response$entity$id, " (", created_property_response$entity$labels$en$value, ")")
 
-    if (is.na(equivalence_property)) {
+    if (!is.na(equivalence_property)) {
     # Add the optional equivalence statement
       wikidata_pid_df <- add_id_statement(
         qid = created_property_response$entity$id,

README.Rmd

@@ -4,7 +4,7 @@ output: github_document
 
 <!-- README.md is generated from README.Rmd. Please edit that file -->
 
-```{r, include = FALSE}
+```{r setupreadme, include = FALSE}
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
@@ -19,7 +19,7 @@ knitr::opts_chunk$set(
 [![Lifecycle: experimental](https://img.shields.io/badge/lifecycle-experimental-orange.svg)](https://lifecycle.r-lib.org/articles/stages.html#experimental)
 [![CRAN status](https://www.r-pkg.org/badges/version/wbdataset)](https://CRAN.R-project.org/package=wbdataset)
 [![devel-version](https://img.shields.io/badge/devel%20version-0.1.1014-blue.svg)](https://github.com/dataobservatory-eu/wbdataset)
-[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.13972192.svg)]
+[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.13972192.svg)
 [![Codecov test coverage](https://codecov.io/gh/dataobservatory-eu/wbdataset/graph/badge.svg)](https://app.codecov.io/gh/dataobservatory-eu/wbdataset)
 <!-- badges: end -->
 

README.md

@@ -10,7 +10,7 @@ experimental](https://img.shields.io/badge/lifecycle-experimental-orange.svg)](h
 [![CRAN
 status](https://www.r-pkg.org/badges/version/wbdataset)](https://CRAN.R-project.org/package=wbdataset)
 [![devel-version](https://img.shields.io/badge/devel%20version-0.1.1014-blue.svg)](https://github.com/dataobservatory-eu/wbdataset)
-\[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.13972192.svg)\]
+\[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.13972192.svg)
 [![Codecov test
 coverage](https://codecov.io/gh/dataobservatory-eu/wbdataset/graph/badge.svg)](https://app.codecov.io/gh/dataobservatory-eu/wbdataset)
 <!-- badges: end -->