small bug fixes

Author: antaldaniel

R/check_existing_item.R

@@ -95,8 +95,11 @@ check_existing_item <- function(search_term,
     logical(1)
   )
 
+  if (!is.logical(exact_match)) message (matching_props[exact_match])
+
   if (sum(exact_match) > 1) {
-    stop("Multiple items [", paste(matching_items, collapse = ", "), "] are matching '", search_term, "' in language='", language, "'.")
+    stop("Multiple items [", paste(matching_items, collapse = ", "),
+         "] are matching '", search_term, "' in language='", language, "'.")
   }
 
   if (!any(exact_match)) {
@@ -121,7 +124,9 @@ check_existing_item <- function(search_term,
     action = action,
     id_on_target = matching_item_data$id,
     label = matching_item_data$label,
-    description = ifelse(is.null(matching_item_data$description), "", matching_item_data$description),
+    description = ifelse(is.null(matching_item_data$description),
+                         "",
+                         matching_item_data$description),
     language = language,
     datatype = "wikibase-item",
     wikibase_api_url = wikibase_api_url,

R/check_existing_property.R

@@ -97,6 +97,8 @@ check_existing_property <- function(
     logical(1)
   )
 
+  if (!is.logical(exact_match)) message (matching_props[exact_match])
+
   if (sum(exact_match) > 1) {
     stop("Multiple items [", paste(matching_props, collapse = ", "), "] are matching '", search_term, "' in language='", language, "'.")
   }
@@ -118,7 +120,8 @@ check_existing_property <- function(
 
   matching_property_data <- search_response$search[[which(exact_match)]]
 
-  comment_text <- glue::glue("A property with the label ", search_term, " already exists in this Wikibase.")
+  comment_text <- glue::glue("A property with the label ",
+                             search_term, " already exists in this Wikibase.")
 
   return_dataframe <- data.frame(
     action = action,
@@ -204,7 +207,8 @@ check_existing_property <- function(
                    "wd:", "wbi:"
   )
 
-  return_ds$rowid <- defined(paste0(prefix, as.character(return_ds$id_on_target)),
+  return_ds$rowid <- defined(paste0(prefix,
+                                    as.character(return_ds$id_on_target)),
                              namespace = wikibase_api_url
   )
 

R/create_item.R

@@ -191,8 +191,8 @@ create_item <- function(label,
                           msg = "You do not have a CSRF token"
   )
 
-  assertthat::assert_that(nchar(csrf_token) == 42,
-                          msg = "Your CSRF token should have 42 characters."
+  assertthat::assert_that(nchar(csrf_token) > 10,
+                          msg = "Your CSRF token usually should have 42 characters."
   )
 
   # Posting the new property ----------------------------------------------

R/create_property.R

@@ -235,19 +235,20 @@ create_property <- function(label,
     }
 
     new_description_text <- ""
-    new_descriptions <- created_item_response$entity$descriptions
+    new_descriptions <- created_property_response$entity$descriptions
+
     if ( length(new_descriptions)==0 ) {
       new_description_text <- ""
     } else {
-      new_description_text <- created_item_response$entity$descriptions[[1]]$language
+      new_description_text <- created_property_response$entity$descriptions[[1]]$language
     }
 
     return_dataframe <- data.frame(
       action = "create_property",
       id_on_target = created_property_response$entity$id,
       label = label,
       description =  new_description_text,
-      language =  created_item_response$entity$labels[[1]]$language,
+      language =  created_property_response$entity$labels[[1]]$language,
       datatype = created_property_response$entity$datatype,
       wikibase_api_url = wikibase_api_url,
       equivalence_property =  equivalence_property,