Skip to content

Commit 7620830

Browse files
committed
add mlmonkey to regular deps
1 parent d7ecccb commit 7620830

File tree

6 files changed

+3
-6
lines changed

6 files changed

+3
-6
lines changed

HOWTO.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ Currently you can find the following docker files:
167167
Finally, you can start all services using `docker-compose`:
168168
for example `docker-compose up jupyter`, `docker-compose up api` or `docker-compose up test`.
169169

170-
Do you need a notebook for development? Just run `docker-compose jupyter up`. It will launch a Jupyter Notebook
170+
Do you need a notebook for development? Just run `docker-compose up jupyter`. It will launch a Jupyter Notebook
171171
with access to you local development files.
172172

173173
## Best practices for development

docker/Dockerfile.api

-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@ RUN apt-get update && apt-get install -y python-dev libffi-dev build-essential
33
COPY . /app
44
WORKDIR /app
55
RUN pip install -r requirements.txt
6-
RUN pip install git+https://gitlab.com/dataroots-public/mlmonkey.git
76
EXPOSE 9090
87
ENTRYPOINT ["python", "scripts/api.py"]

docker/Dockerfile.jupyter

-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@ RUN apt-get update && apt-get install -y python-dev libffi-dev build-essential
33
COPY requirements.txt /workspace/
44
WORKDIR /workspace
55
RUN pip install -r requirements.txt
6-
RUN pip install git+https://gitlab.com/dataroots-public/mlmonkey.git
76
EXPOSE 8888
87
ENTRYPOINT ["jupyter", "notebook", "--ip=0.0.0.0", "--port=8888", "--no-browser", "--allow-root"]

docker/Dockerfile.test

-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@ RUN apt-get update && apt-get install -y python-dev libffi-dev build-essential
33
COPY . /app
44
WORKDIR /app
55
RUN pip install -r requirements.txt
6-
RUN pip install git+https://gitlab.com/dataroots-public/mlmonkey.git
76
ENV LOG_LEVEL INFO
87
ENTRYPOINT ["make", "test"]

requirements.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ jupyter>=1.0
1212
graphviz>=0.10
1313
shap>=0.24
1414
plotly>=3.3
15-
connexion[swagger-ui]>=2.0
15+
connexion[swagger-ui]>=2.0
16+
git+https://gitlab.com/dataroots-public/mlmonkey.git

tox.ini

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ envlist = py37
44
[testenv]
55
deps = -rrequirements.txt
66
commands =
7-
pip install git+https://gitlab.com/dataroots-public/mlmonkey.git
87
pytest tests/
98
flake8 src/
109

0 commit comments

Comments
 (0)