From 862d37b1fb35dbc94113cd800e2be51cce7232f6 Mon Sep 17 00:00:00 2001 From: jgough Date: Thu, 18 Apr 2024 11:31:07 +0100 Subject: [PATCH 1/3] Add mmr index filter for list events re: AB#9115 --- datatrails-common-api/assets/v2/assets/listevents.proto | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datatrails-common-api/assets/v2/assets/listevents.proto b/datatrails-common-api/assets/v2/assets/listevents.proto index 74abae5..56c6079 100644 --- a/datatrails-common-api/assets/v2/assets/listevents.proto +++ b/datatrails-common-api/assets/v2/assets/listevents.proto @@ -139,6 +139,9 @@ message ListEventsRequest { description: "filters" } ]; + + // filter events by mmr index + int32 mmr_index = 24 [(validate.rules).int32.gte = 0]; } message ListEventsResponse { From 01eeeac439922c0de85199cc21ee97995870d2f9 Mon Sep 17 00:00:00 2001 From: jgough Date: Thu, 18 Apr 2024 11:50:34 +0100 Subject: [PATCH 2/3] fixup int64 --- datatrails-common-api/assets/v2/assets/listevents.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datatrails-common-api/assets/v2/assets/listevents.proto b/datatrails-common-api/assets/v2/assets/listevents.proto index 56c6079..ccc3e9a 100644 --- a/datatrails-common-api/assets/v2/assets/listevents.proto +++ b/datatrails-common-api/assets/v2/assets/listevents.proto @@ -141,7 +141,7 @@ message ListEventsRequest { ]; // filter events by mmr index - int32 mmr_index = 24 [(validate.rules).int32.gte = 0]; + int64 mmr_index = 24 [(validate.rules).int64.gte = 0]; } message ListEventsResponse { From fa7697a78c601f65e2c07a01e08548ae60241c02 Mon Sep 17 00:00:00 2001 From: jgough Date: Thu, 18 Apr 2024 14:06:07 +0100 Subject: [PATCH 3/3] Ensure the mmr index filter for list events is optional re: AB#9115 --- datatrails-common-api/assets/v2/assets/listevents.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datatrails-common-api/assets/v2/assets/listevents.proto b/datatrails-common-api/assets/v2/assets/listevents.proto index ccc3e9a..c6847d9 100644 --- a/datatrails-common-api/assets/v2/assets/listevents.proto +++ b/datatrails-common-api/assets/v2/assets/listevents.proto @@ -141,7 +141,7 @@ message ListEventsRequest { ]; // filter events by mmr index - int64 mmr_index = 24 [(validate.rules).int64.gte = 0]; + optional int64 mmr_index = 24 [(validate.rules).int64.gte = 0]; } message ListEventsResponse {