Skip to content

Commit e48e5d8

Browse files
authored
Merge pull request #33 from datatrails/dev/henry/9754-incomplete-field-reservation
improve deleted field reservation for list events
2 parents ad82c68 + 51073f8 commit e48e5d8

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

datatrails-common-api/assets/v2/assets/listevents.proto

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,12 @@ message ListEventsRequest {
4343
Principal principal_declared = 6;
4444
Principal principal_accepted = 7;
4545

46-
// what was field 8 called?
4746
reserved 8;
47+
reserved "attributes";
4848

49-
// where are fields 9,10 ?
49+
// AFAICT fields 9 and 10 were skipped over when the message was first defined. Reserving
50+
// for safety.
51+
reserved 9, 10;
5052

5153
// Filtering
5254
google.protobuf.Timestamp timestamp_accepted_since = 11 [ (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {

0 commit comments

Comments
 (0)