Skip to content

Commit ee862b5

Browse files
committed
Crashfix and GUI updates for Morph Selection Dialog (Double-dipping, etc)
1 parent fb5ae99 commit ee862b5

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

include/DzBridgeMorphSelectionDialog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ namespace DzBridgeNameSpace
204204
QTreeWidgetItem* charactersTreeItem;
205205
QCheckBox* autoJCMCheckBox;
206206
QCheckBox* fakeDualQuatCheckBox;
207-
QPushButton* AddConnectedMorphsButton;
207+
QPushButton* addConnectedMorphsButton;
208208

209209
QCheckBox* allowMorphDoubleDippingCheckBox;
210210

include/common_version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
#define COMMON_MAJOR 2023
66
#define COMMON_MINOR 1
77
#define COMMON_REV 0
8-
#define COMMON_BUILD 50
8+
#define COMMON_BUILD 52
99

1010
#define COMMON_VERSION DZ_MAKE_VERSION( COMMON_MAJOR, COMMON_MINOR, COMMON_REV, COMMON_BUILD )

src/DzBridgeMorphSelectionDialog.cpp

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -162,21 +162,23 @@ DzBridgeMorphSelectionDialog::DzBridgeMorphSelectionDialog(QWidget *parent) :
162162
fakeDualQuatCheckBox->setVisible(false);
163163
fakeDualQuatCheckBox->setWhatsThis("Adds additional JCMs that fake the difference between Linear Blending and Dual Quaternion Skinning.");
164164

165-
allowMorphDoubleDippingCheckBox = new QCheckBox(tr("Allow Morph Double-Dipping."));
165+
allowMorphDoubleDippingCheckBox = new QCheckBox(tr("Allow Morph Double-Dipping"));
166166
allowMorphDoubleDippingCheckBox->setChecked(false);
167167
allowMorphDoubleDippingCheckBox->setVisible(true);
168-
QString sAllowDoubleDippingHelpText = QString(tr("Allow Connected Morphs such as Victoria 9 and Victoria 9 Head \
169-
and Victoria 9 Body to all fully contribute to the exported blendshape when they are exported simultaneously. \
170-
WARNING: this will cause 200% or similar morph distortion when they are all applied together and may break \
171-
functionallity for some Morph and JCM products."));
168+
QString sAllowDoubleDippingHelpText = QString(tr("\
169+
Allow Connected Morphs such as Victoria 9 and Victoria 9 Head and Victoria 9 Body to all fully contribute \n\
170+
to the exported blendshape when they are exported simultaneously. \n\n\
171+
WARNING: this will cause 200% or similar morph distortion when they are all applied together and may break \n\
172+
functionality for some Morph and JCM products.\
173+
"));
172174
allowMorphDoubleDippingCheckBox->setWhatsThis(sAllowDoubleDippingHelpText);
173175
allowMorphDoubleDippingCheckBox->setToolTip(sAllowDoubleDippingHelpText);
174176

175-
QPushButton* AddConnectedMorphsButton = new QPushButton("Add Connected Morphs");
176-
AddConnectedMorphsButton->setVisible(false);
177+
addConnectedMorphsButton = new QPushButton("Add Connected Morphs");
178+
addConnectedMorphsButton->setVisible(false);
177179
QString sAddConnectedMorphsHelpText = QString(tr("Add any morphs or property sliders which can contribute to strength of exported morphs."));
178-
AddConnectedMorphsButton->setWhatsThis(sAddConnectedMorphsHelpText);
179-
AddConnectedMorphsButton->setToolTip(sAddConnectedMorphsHelpText);
180+
addConnectedMorphsButton->setWhatsThis(sAddConnectedMorphsHelpText);
181+
addConnectedMorphsButton->setToolTip(sAddConnectedMorphsHelpText);
180182

181183
((QGridLayout*)JCMGroupBox->layout())->addWidget(ArmsJCMButton, 0, 0);
182184
((QGridLayout*)JCMGroupBox->layout())->addWidget(LegsJCMButton, 0, 1);
@@ -188,7 +190,7 @@ functionallity for some Morph and JCM products."));
188190
MorphGroupBox->layout()->addWidget(FaceGroupBox);
189191
MorphGroupBox->layout()->addWidget(autoJCMCheckBox);
190192
MorphGroupBox->layout()->addWidget(fakeDualQuatCheckBox);
191-
MorphGroupBox->layout()->addWidget(AddConnectedMorphsButton);
193+
MorphGroupBox->layout()->addWidget(addConnectedMorphsButton);
192194
MorphGroupBox->layout()->addWidget(allowMorphDoubleDippingCheckBox);
193195

194196
if (!settings->value("AutoJCMEnabled").isNull())
@@ -208,7 +210,7 @@ functionallity for some Morph and JCM products."));
208210
connect(FaceFX8Button, SIGNAL(released()), this, SLOT(HandleFaceFXGenesis8Button()));
209211
connect(autoJCMCheckBox, SIGNAL(clicked(bool)), this, SLOT(HandleAutoJCMCheckBoxChange(bool)));
210212
connect(fakeDualQuatCheckBox, SIGNAL(clicked(bool)), this, SLOT(HandleFakeDualQuatCheckBoxChange(bool)));
211-
connect(AddConnectedMorphsButton, SIGNAL(clicked(bool)), this, SLOT(HandleAddConnectedMorphs()));
213+
connect(addConnectedMorphsButton, SIGNAL(clicked(bool)), this, SLOT(HandleAddConnectedMorphs()));
212214

213215
treeLayout->addWidget(MorphGroupBox);
214216
morphsLayout->addLayout(treeLayout);
@@ -1426,7 +1428,7 @@ void DzBridgeMorphSelectionDialog::SetAutoJCMVisible(bool bVisible)
14261428
return;
14271429
autoJCMCheckBox->setVisible(bVisible);
14281430
fakeDualQuatCheckBox->setVisible(bVisible);
1429-
AddConnectedMorphsButton->setVisible(bVisible);
1431+
addConnectedMorphsButton->setVisible(bVisible);
14301432
update();
14311433
}
14321434

0 commit comments

Comments
 (0)