Skip to content

Commit c889fea

Browse files
committed
Merge pull request nodegit#1030 from smith-kyle/oid-leak
Memory management: plugged leak in fastWalk
2 parents 7c2f7ef + 7ed0303 commit c889fea

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

generate/templates/manual/revwalk/fast_walk.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,11 @@ void GitRevwalk::FastWalkWorker::HandleOKCallback()
7373
unsigned int size = baton->out->size();
7474
Local<Array> result = Nan::New<Array>(size);
7575
for (unsigned int i = 0; i < size; i++) {
76-
Nan::Set(result, Nan::New<Number>(i), GitOid::New(baton->out->at(i), false));
76+
Nan::Set(result, Nan::New<Number>(i), GitOid::New(baton->out->at(i), true));
7777
}
7878

79+
delete baton->out;
80+
7981
Local<v8::Value> argv[2] = {
8082
Nan::Null(),
8183
result

0 commit comments

Comments
 (0)