Create raises error on duplicate bucket name #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds Gemfile for those that wish to use Bundler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of lib/aws/s3/bucket.rb included a comment that said a AWS::S3::BucketAlreadyExists exception would be raised if you try to create a Bucket with a name that already exists, however this behavior was not present. It seems that Amazon's API does not do this either, even though they mention that as an error response at http://docs.amazonwebservices.com/AmazonS3/2006-03-01/index.html?RESTCommonResponseHeaders.html
This feature branch adds logic within Bucket.create to do a find on the name, and raise BucketAlreadyExists if a bucket is found, otherwise it will create the bucket.