-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1135: Migrate dbt-adapters into a package sub-directory #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo docs, docs updates will happen separately
VanTudor
pushed a commit
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Colin Rogers <[email protected]>
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that all of the first party adapters are in the monorepo, we should update
dbt-adapters
anddbt-tests-adapter
to use the same package subdirectory convention as the other packages in this repo.Solution
dbt/
intodbt-adapters/src/
tests/
intodbt-adapters/
.changes/
intodbt-adapters/
dbt-adapters/
(e.g.README.md
,pyproject.toml
, e.g.)README.md
andCONTRIBUTING.md
in the root, to be updated during the docs PRdbt-adapters
anddbt-tests-adapter
to point to the new directoriesdagger
script fordbt-spark
to copydbt-adapters
anddbt-tests-adapter
files over to the image as well since they get installed locallyCI checks run against this branch:
dbt-adapters
: https://github.com/dbt-labs/dbt-adapters/actions/runs/12995141252dbt-snowflake
(ref localdbt-adapters
): https://github.com/dbt-labs/dbt-adapters/actions/runs/12995153939dbt-adapters
: https://github.com/dbt-labs/dbt-adapters/actions/runs/12995197430Failed tests:
dbt-spark
unit tests and integration tests are failing because we cannot use relative pathing the way thatdagger
is currently configured in the repo. That will be left as a separate PR. Once this PR is merged,dbt-spark
tests will be able to finddbt-adapters
in the correct place.