Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1135: Migrate dbt-adapters into a package sub-directory #746

Merged
merged 15 commits into from
Jan 27, 2025

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jan 27, 2025

Problem

Now that all of the first party adapters are in the monorepo, we should update dbt-adapters and dbt-tests-adapter to use the same package subdirectory convention as the other packages in this repo.

Solution

  • move dbt/ into dbt-adapters/src/
  • move tests/ into dbt-adapters/
  • move .changes/ into dbt-adapters/
  • move root level files into dbt-adapters/ (e.g. README.md, pyproject.toml, e.g.)
  • leave copies of README.md and CONTRIBUTING.md in the root, to be updated during the docs PR
  • update workflows to remove the package directory workflow
  • update all references to dbt-adapters and dbt-tests-adapter to point to the new directories
  • update dagger script for dbt-spark to copy dbt-adapters and dbt-tests-adapter files over to the image as well since they get installed locally

CI checks run against this branch:

Failed tests:

dbt-spark unit tests and integration tests are failing because we cannot use relative pathing the way that dagger is currently configured in the repo. That will be left as a separate PR. Once this PR is merged, dbt-spark tests will be able to find dbt-adapters in the correct place.

@mikealfare mikealfare self-assigned this Jan 27, 2025
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Jan 27, 2025
VanTudor pushed a commit that referenced this pull request Jan 28, 2025
colin-rogers-dbt pushed a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants