Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbt-snowflake] Expose ocsp_fail_open as a parameter #794

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcrobak
Copy link

@jcrobak jcrobak commented Feb 5, 2025

resolves #793

Problem

The setting ocsp_fail_open, which is a parameter to the snowflake-connector-python, is not currently exposed in the dbt-snowflake adapter.

Solution

We only pass along the parameter when it's set so that we can defer to the builtin default of the snowflake-connector-python (historically the default has changed between versions).

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@jcrobak jcrobak requested a review from a team as a code owner February 5, 2025 21:43
Copy link

cla-bot bot commented Feb 5, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @jcrobak

We only pass along the parameter when it's set so that we can defer to
the builtin default of the snowflake-connector-python (historically the
default has changed between versions).
@jcrobak jcrobak force-pushed the dbt-snowflake-ocsp-fail-open branch from 4773d84 to f55f0be Compare February 6, 2025 17:23
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Feb 6, 2025
@cla-bot cla-bot bot temporarily deployed to dbt-snowflake February 6, 2025 17:24 Inactive
@jcrobak jcrobak changed the title Expose ocsp_fail_open as a parameter [dbt-snowflake] Expose ocsp_fail_open as a parameter Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support ocsp_fail_open setting in dbt-snowflake
1 participant