Add invocation_started_at #11291
Open
Add invocation_started_at #11291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11291 +/- ##
==========================================
- Coverage 88.95% 88.91% -0.05%
==========================================
Files 189 189
Lines 24139 24140 +1
==========================================
- Hits 21473 21463 -10
- Misses 2666 2677 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11272
Problem
We want to store a time approximating the time the run started at, which in many cases will be more useful than the "generated_at" timestamp, which happens toward the end of a run.
Solution
We already save an invocation_id which is generated on new runs, so we add an additional "invocation_started_at", which is generated and reset in the same place as "invocation_id".
Note: this requires changes in dbt-common. A dbt-common branch is included here, but a new dbt-common release will be needed before merging this.
Checklist