Merge pull request #442 from dbt-labs/fix/fct_chained_views

Author: b-per

integration_tests/dbt_project.yml

@@ -67,4 +67,5 @@ vars:
   new_model_type_folder_name: 'my_new_models'
   new_model_type_prefixes: 'nwmdl_'
   insert_batch_size: 100
-  too_many_joins_threshold: 3
+  too_many_joins_threshold: 3
+  chained_views_threshold: 2

integration_tests/seeds/performance/test_fct_chained_views_dependencies.csv

@@ -1,17 +1,2 @@
 parent,child,distance
 stg_model_1,dim_model_7,3
-stg_model_1,int_model_5,2
-stg_model_2,dim_model_7,2
-int_model_4,dim_model_7,2
-stg_model_1,dim_model_7,2
-stg_model_4,dim_model_7,1
-stg_model_2,stg_model_4,1
-int_model_4,int_model_5,1
-int_model_5,dim_model_7,1
-stg_model_1,int_model_5,1
-stg_model_1,int_model_4,1
-fct_model_9,stg_model_5,1
-stg_model_3,fct_model_6,1
-stg_model_1,fct_model_10,1
-stg_model_2,fct_model_10,1
-stg_model_3,fct_model_10,1

models/marts/performance/fct_chained_views_dependencies.sql

@@ -16,6 +16,7 @@ final as (
     from all_relationships
     where is_dependent_on_chain_of_views
     and child_resource_type = 'model'
+    and distance > {{ var('chained_views_threshold') }}
 )
 
 select * from final

models/marts/performance/performance.yml

@@ -6,11 +6,6 @@ models:
       This returns models dependent on chains of "non-physically-materialized" models (views and ephemerals),
       highlighting potential cases for improving performance by switching the materialization of model(s) within 
       the chain to table or incremental. 
-    columns:
-      - name: distance
-        tests:
-          - dbt_utils.accepted_range:
-              name: valid_chained_views_dependencies
-              max_value: "{{ var('chained_views_threshold') }}"
-              inclusive: false
-              severity: warn
+    tests:
+      - is_empty:
+          severity: warn