Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arg from filter_exceptions #416

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

b-per
Copy link
Collaborator

@b-per b-per commented Jan 24, 2024

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Description & motivation

Half between bugfix and new functionality. This just simplifies how we filter the exceptions.

This is a breaking change for people who overwrite the definition of filter_exceptions() in their own project, so we should release it only in a new minor and not a patch.

It would be good to update the release notes and/or changelog mentioning the breaking change as well.

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@graciegoheen
Copy link
Collaborator

What's the reason for this change? Just to simplify the macro? Changes look good!

@b-per
Copy link
Collaborator Author

b-per commented Jan 24, 2024

The main reason is that I only learned today that we could access model from a macro without having to pass it as an argument of the macro itself. And, yes, doing so makes it cleaner/easier to maintain.

We actually had a bug previously with the macro not being defined properly in some new models.

Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@graciegoheen graciegoheen merged commit 7987ee8 into main Feb 1, 2024
7 checks passed
@graciegoheen graciegoheen deleted the update-filter-exceptions branch February 1, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants