Skip to content

Commit def6d29

Browse files
authored
Merge branch 'test-vale' into test-vale-pr
2 parents 793245a + 2e7be86 commit def6d29

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

.github/workflows/vale.yml

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Lint and suggest
1+
name: Lint and Suggest
22

33
on:
44
pull_request:
@@ -10,48 +10,45 @@ permissions:
1010
pull-requests: write
1111

1212
jobs:
13-
vale: # Vale linting job
13+
vale:
1414
runs-on: ubuntu-latest
1515

1616
steps:
1717
- name: Checkout code
1818
uses: actions/checkout@v3
1919
with:
20-
fetch-depth: 0 # Fetch all history so we can access all commits
20+
fetch-depth: 0
2121

2222
- name: Install Vale
2323
uses: errata-ai/vale-action@v2
24-
25-
- name: Install jq
26-
run: sudo apt-get install -y jq
24+
with:
25+
version: latest
2726

2827
- name: Get changed files
2928
id: changed-files
3029
run: |
3130
BASE_SHA=$(git merge-base origin/${{ github.event.pull_request.base.ref }} ${{ github.sha }})
3231
CHANGED_FILES=$(git diff --name-only $BASE_SHA ${{ github.sha }} -- '*.md')
3332
echo "CHANGED_FILES=$CHANGED_FILES" >> $GITHUB_ENV
34-
echo "CHANGED_FILES=$(echo $CHANGED_FILES | jq -R -s -c 'split(\"\n\")[:-1]')" >> $GITHUB_ENV
33+
echo "::set-output name=files::$(echo $CHANGED_FILES | jq -R -s -c 'split(\"\\n\")[:-1]')"
3534
3635
- name: Print Changed Files
3736
run: echo $CHANGED_FILES
3837

3938
- name: Run Vale on changed files
4039
run: |
41-
for file in ${{ env.CHANGED_FILES }}; do
40+
for file in $(echo ${{ steps.changed-files.outputs.files }} | jq -r '.[]'); do
4241
echo "Running Vale on $file"
43-
vale --output=JSON $file > "vale_output_${file//\//_}.json"
44-
vale --output=edit $file > "vale_output_${file//\//_}_edit.md"
42+
vale --output=JSON "$file" > "vale_output_${file//\//_}.json"
4543
done
4644
echo "Vale outputs:"
4745
ls -l
4846
49-
- name: Simulate Vale changes
47+
- name: Apply Vale suggestions
5048
run: |
51-
mkdir -p simulated_changes
49+
mkdir -p suggested_changes
5250
for file in $(echo ${{ steps.changed-files.outputs.files }} | jq -r '.[]'); do
53-
cp "$file" "simulated_changes/$(basename "$file")"
54-
vale --output=edit "simulated_changes/$(basename "$file")"
51+
vale --output=line "$file" | grep -oP 'Consider changing.*' > suggested_changes/"$(basename "$file")".suggestions
5552
done
5653
5754
- name: Upload Vale results
@@ -60,27 +57,27 @@ jobs:
6057
name: vale-results
6158
path: '*.json'
6259

63-
- name: Upload simulated changes
60+
- name: Upload suggested changes
6461
uses: actions/upload-artifact@v3
6562
with:
66-
name: simulated-changes
67-
path: simulated_changes
63+
name: suggested-changes
64+
path: suggested_changes/
6865

6966
suggest:
7067
runs-on: ubuntu-latest
71-
needs: vale # This ensures the suggest job runs after the vale job
68+
needs: vale
7269

7370
steps:
7471
- name: Checkout code
7572
uses: actions/checkout@v3
7673

77-
- name: Download simulated changes
74+
- name: Download suggested changes
7875
uses: actions/download-artifact@v3
7976
with:
80-
name: simulated-changes
77+
name: suggested-changes
8178

8279
- name: List downloaded files
83-
run: ls -l simulated_changes
80+
run: ls -l suggested_changes
8481

8582
- name: Suggest changes
8683
uses: parkerbxyz/suggest-changes@v1

styles/custom/Typos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
extends: substitution
22

3-
message: "Oops there's a typo! Consider changing '{{.Match}}' to '{{.Suggestions}}.'"
3+
message: "Oops there's a typo! Consider changing '%s' instead of '%s'"
44
level: warning
55
swap:
66
- teh: the

0 commit comments

Comments
 (0)