From 8ece79f25fc4b4c3059b6eb60308e142a807a0a3 Mon Sep 17 00:00:00 2001 From: Paul Yang Date: Wed, 11 Dec 2024 13:29:27 -0800 Subject: [PATCH] Remove redundant test. --- .../integration/test_mf_engine.py | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/tests_metricflow/integration/test_mf_engine.py b/tests_metricflow/integration/test_mf_engine.py index b933835aa8..9aa1373701 100644 --- a/tests_metricflow/integration/test_mf_engine.py +++ b/tests_metricflow/integration/test_mf_engine.py @@ -3,8 +3,6 @@ from _pytest.fixtures import FixtureRequest from metricflow_semantics.test_helpers.config_helpers import MetricFlowTestConfiguration -from metricflow.engine.metricflow_engine import MetricFlowExplainResult, MetricFlowQueryRequest -from metricflow.sql.optimizer.optimization_levels import SqlQueryOptimizationLevel from tests_metricflow.integration.conftest import IntegrationTestHelpers from tests_metricflow.snapshot_utils import assert_object_snapshot_equal @@ -18,26 +16,3 @@ def test_list_dimensions( # noqa: D103 obj_id="result0", obj=sorted([dim.qualified_name for dim in it_helpers.mf_engine.list_dimensions()]), ) - - -def test_sql_optimization_level(it_helpers: IntegrationTestHelpers) -> None: - """Check that different SQL optimization levels produce different SQL.""" - assert ( - SqlQueryOptimizationLevel.default_level() != SqlQueryOptimizationLevel.O0 - ), "The default optimization level should be different from the lowest level." - explain_result_at_default_level: MetricFlowExplainResult = it_helpers.mf_engine.explain( - MetricFlowQueryRequest.create_with_random_request_id( - metric_names=("bookings",), - group_by_names=("metric_time",), - sql_optimization_level=SqlQueryOptimizationLevel.default_level(), - ) - ) - explain_result_at_level_0: MetricFlowExplainResult = it_helpers.mf_engine.explain( - MetricFlowQueryRequest.create_with_random_request_id( - metric_names=("bookings",), - group_by_names=("metric_time",), - sql_optimization_level=SqlQueryOptimizationLevel.O0, - ) - ) - - assert explain_result_at_default_level.rendered_sql.sql_query != explain_result_at_level_0.rendered_sql.sql_query