Merge pull request #294 from transform-data/qmalcolm--fix-dbt-imports

Fix dbt imports

Author: QMalcolm

.github/workflows/ci-metricflow-unit-tests.yaml

@@ -32,7 +32,7 @@ jobs:
         run: pip install poetry==1.1.15 && poetry config virtualenvs.create false
 
       - name: Install Metricflow
-        run: poetry install -E dbt-snowflake
+        run: poetry install
 
       - name: Run MetricFlow Unit tests suites
         run: pytest metricflow/test

.github/workflows/ci-schema-consistency.yaml

@@ -36,7 +36,7 @@ jobs:
         run: pip install poetry==1.1.15 && poetry config virtualenvs.create false
 
       - name: Install Metricflow
-        run: poetry install -E dbt-snowflake
+        run: poetry install
 
       - name: Generate JSON Schema
         run: python3 metricflow/model/parsing/explicit_schema.py

metricflow/engine/metricflow_engine.py

@@ -19,7 +19,7 @@
 from metricflow.dataset.convert_data_source import DataSourceToDataSetConverter
 from metricflow.engine.models import Dimension, Materialization, Metric
 from metricflow.engine.time_source import ServerTimeSource
-from metricflow.engine.utils import build_user_configured_model_from_config, build_user_configured_model_from_dbt_config
+from metricflow.engine.utils import build_user_configured_model_from_config
 from metricflow.execution.execution_plan import ExecutionPlan, SqlQuery
 from metricflow.execution.execution_plan_to_text import execution_plan_to_text
 from metricflow.execution.executor import SequentialPlanExecutor
@@ -276,6 +276,13 @@ def from_config(handler: YamlFileHandler) -> MetricFlowEngine:
         # Ideally we should put this getting of of CONFIG_DBT_REPO in a helper
         dbt_repo = handler.get_value(CONFIG_DBT_REPO) or ""
         if dbt_repo.lower() in ["yes", "y", "true", "t", "1"]:
+            # This import results in eventually importing dbt, and dbt is an
+            # optional dep meaning it isn't guaranteed to be installed. If the
+            # import is at the top ofthe file MetricFlow will blow up if dbt
+            # isn't installed. Thus by importing it here, we only run into the
+            # exception if this conditional is hit without dbt installed
+            from metricflow.engine.utils import build_user_configured_model_from_dbt_config
+
             semantic_model = SemanticModel(build_user_configured_model_from_dbt_config(handler))
         else:
             semantic_model = SemanticModel(build_user_configured_model_from_config(handler))

metricflow/engine/utils.py

@@ -7,7 +7,6 @@
 from metricflow.configuration.yaml_handler import YamlFileHandler
 from metricflow.errors.errors import ModelCreationException
 from metricflow.model.objects.user_configured_model import UserConfiguredModel
-from metricflow.model.parsing.dbt_dir_to_model import parse_dbt_project_to_model
 from metricflow.model.parsing.dir_to_model import ModelBuildResult, parse_directory_of_yaml_files_to_model
 from metricflow.sql_clients.common_client import not_empty
 
@@ -52,6 +51,13 @@ def model_build_result_from_dbt_config(
     """
     dbt_models_path = path_to_models(handler=handler)
     try:
+        # This import results in eventually importing dbt, and dbt is an
+        # optional dep meaning it isn't guaranteed to be installed. If the
+        # import is at the top ofthe file MetricFlow will blow up if dbt
+        # isn't installed. Thus by importing it here, we only run into the
+        # exception if this method is called without dbt installed.
+        from metricflow.model.parsing.dbt_dir_to_model import parse_dbt_project_to_model
+
         return parse_dbt_project_to_model(dbt_models_path)
     except Exception as e:
         raise ModelCreationException from e