add data set "with empty login/name Attributes" use case

Author: Patrick-Eichhorn

script/ldap.py

@@ -80,12 +80,16 @@ def fetch_users_of_group(group_name):
                                                                 paged_size=5)
             for user_set in user_data:
                 data_set = user_set["attributes"]
+                login = clean_attribute(data_set[configuration.LDAP_USER_LOGIN_ATTRIBUTE])
+                name = clean_attribute(data_set[configuration.LDAP_USER_NAME_ATTRIBUTE])
                 mail = clean_attribute(data_set[configuration.LDAP_USER_MAIL_ATTRIBUTE])
+                if not login or not name:
+                    continue
                 if not mail:
                     mail = clean_attribute(data_set[configuration.LDAP_USER_LOGIN_ATTRIBUTE])
                 result.append({
-                    "login": clean_attribute(data_set[configuration.LDAP_USER_LOGIN_ATTRIBUTE]),
-                    "name": clean_attribute(data_set[configuration.LDAP_USER_NAME_ATTRIBUTE]),
+                    "login": login,
+                    "name": name,
                     "email": mail
                 })
     connection.unbind()

tests/test_ldap.py

@@ -44,8 +44,8 @@ def test_creates_connection(self, mock_configuration, mock_server, mock_connecti
         self.assertEqual(output, True)
         self.assertEqual(mock_server.call_count, 1)
         self.assertEqual(mock_connection.call_count, 1)
-        mock_server.assert_called_with("my_url", get_info=ALL)
-        mock_connection.assert_called_with(mock_server_object, user="my_url\\my_user", password="my_password",
+        mock_server.assert_called_with("my_url", get_info=ALL, use_ssl=ANY, port=ANY)
+        mock_connection.assert_called_with(mock_server_object, user="my_user", password="my_password",
                                            authentication=NTLM, read_only=True)