Skip to content

Commit 52ecdaa

Browse files
fix(ui): Fix incorrect env var existence check (caraml-dev#102)
* Fix incorrect env var existence check * Add codecov threshold
1 parent 5d5a1b9 commit 52ecdaa

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

.github/workflows/ci-pipeline.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ jobs:
130130
name: api-test
131131
token: ${{ secrets.CODECOV_TOKEN }}
132132
working-directory: ./api
133+
codecov_yml_path: ../.github/workflows/codecov-config/codecov.yml
133134

134135
e2e-test:
135136
runs-on: ubuntu-latest
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
coverage:
2+
status:
3+
patch:
4+
default:
5+
threshold: 0.03%

ui/packages/app/src/config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const getEnv = env => {
2-
return window.env && window.env[env] ? window.env[env] : process.env[env];
2+
return window.env && env in window.env ? window.env[env] : process.env[env];
33
};
44

55
export const sentryConfig = {

0 commit comments

Comments
 (0)