Skip to content

Commit c67fd99

Browse files
committed
build: drop usage of .postN
1 parent 7dca366 commit c67fd99

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/build_and_release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ on:
77
required: true
88
default: 3.4.1
99
version-tag:
10-
description: Python package version to release to PyPI (without 'v')
10+
description: Python package version to release to PyPI (without 'v', last digit is the build number)
1111
required: true
12-
default: 3.4.1.post1
12+
default: 3.4.1.1
1313
dry-run:
1414
description: Dry run
1515
type: boolean

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ Go to Github Actions and run the `Build and Release` workflow.
4343

4444
Version rule:
4545

46-
3.4.1.post2: 3.4.1 is the APBS version, postN can increase with the changes of the package and the builds.
46+
3.4.1.2:
47+
48+
- 3.4.1 is the APBS version
49+
- the last digit (.2) is the patch/build number. It increases as we rebuild the wheels with different configurations or update the python API.
4750

4851

4952
### Running locally
@@ -73,7 +76,7 @@ Build four wheels on all platforms. Basically it will put the binaries in the `s
7376
```bash
7477
# first arg: APBS version to find in `data/` (i.e. data/apbs-3.4.1/APBS-3.4.1.Linux)
7578
# second arg: wheel version
76-
bash build_python.sh 3.4.1 3.4.1.post2
79+
bash build_python.sh 3.4.1 3.4.1.2
7780
```
7881

7982
Test the wheel

build_python.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
if [ "$#" -ne 2 ]; then
22
echo "Build python wheels in a temp directory."
33
echo "Usage: $0 <apbs_version> <py_package_version>"
4-
echo "Example: $0 3.4.1 3.4.1.post4"
4+
echo "Example: $0 3.4.1 3.4.1.4"
5+
echo "The python package version should be the same as the APBS version plus a patch (build) version."
56
exit 1
67
fi
78

0 commit comments

Comments
 (0)