Skip to content

Commit 55bece6

Browse files
authored
Merge branch 'main' into feat/testing-api-tool
2 parents 0397749 + 82dc93b commit 55bece6

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

.github/workflows/build-and-publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ jobs:
4040
s3-bucket: ${{ secrets.SDK_TEAM_S3_BUCKET }}
4141
s3-bucket-key-prefix: '@dcl/protocol/branch/${{ steps.myref.outputs.branch }}'
4242
s3-bucket-region: ${{ secrets.SDK_TEAM_AWS_REGION }}
43-
4443
## inform gitlab after publishing to proceed with CDN propagation
4544
gitlab-token: ${{ secrets.GITLAB_TOKEN }}
4645
gitlab-pipeline-url: ${{ secrets.GITLAB_URL }}

proto/decentraland/kernel/apis/communications_controller.proto

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,22 @@ syntax = "proto3";
22
package decentraland.kernel.apis;
33

44
message RealSendRequest {
5-
string message = 1;
5+
string message = 1;
66
}
77

88
message RealSendResponse {}
99

10+
message SendBinaryRequest {
11+
repeated bytes data = 1;
12+
}
13+
14+
message SendBinaryResponse {
15+
repeated bytes data = 1;
16+
}
17+
1018
service CommunicationsControllerService {
11-
// @deprecated - This API should use a bidirectional binary stream in sdk7
12-
// https://github.com/decentraland/sdk/issues/582
13-
rpc Send(RealSendRequest) returns (RealSendResponse) {}
19+
// @deprecated - This API should use a bidirectional binary stream in sdk7
20+
// https://github.com/decentraland/sdk/issues/582
21+
rpc Send(RealSendRequest) returns (RealSendResponse) {}
22+
rpc SendBinary(SendBinaryRequest) returns (SendBinaryResponse) {}
1423
}

0 commit comments

Comments
 (0)