fix experimental validate check

Author: gonpombo8

.github/workflows/validate.yml

@@ -13,10 +13,17 @@ jobs:
       - name: install
         run: make install
       - name: buf breaking
-        run: make buf-breaking
+        env:
+          BASE_BRANCH: ${{ github.base_ref || 'main' }}
+        run: |
+          echo "github.base_ref=${{ github.base_ref }}"
+          echo "BASE_BRANCH=$BASE_BRANCH"
+          make buf-breaking
       - name: buf lint
         run: make buf-lint
       - name: build and compile test
         run: make test
       - name: run the check script
+        env:
+          BASE_BRANCH: ${{ github.base_ref || 'main' }}
         run: ./scripts/check-proto-compabitility.sh

Makefile

@@ -14,7 +14,7 @@ buf-build: node_modules/.bin/buf
 	./node_modules/.bin/buf build proto/
 
 buf-breaking: node_modules/.bin/buf
-	./node_modules/.bin/buf breaking proto/ --against 'https://github.com/decentraland/protocol.git#subdir=proto'
+	./node_modules/.bin/buf breaking proto/ --against 'https://github.com/decentraland/protocol.git#branch=$(or $(BASE_BRANCH),main),subdir=proto'
 
 test: buf-lint
 	bash scripts/test.sh

scripts/check-proto-compabitility.sh

@@ -1,21 +1,24 @@
 #!/bin/bash
 set -e -x
 
-# Download the main branch ref zip
-protocol_main_zip_url="https://github.com/decentraland/protocol/archive/refs/heads/main.zip"
-protocol_main_zip_local="./protocol-main.zip"
+# Use BASE_BRANCH environment variable or default to main
+BRANCH="${BASE_BRANCH:-main}"
+
+# Download the reference branch zip
+protocol_branch_zip_url="https://github.com/decentraland/protocol/archive/refs/heads/${BRANCH}.zip"
+protocol_branch_zip_local="./protocol-${BRANCH}.zip"
 
 TMP_ZIP_DIR=$(mktemp -d)
 
-curl -L "$protocol_main_zip_url" -o "$protocol_main_zip_local"
-unzip "$protocol_main_zip_local" -d "$TMP_ZIP_DIR"
-rm "$protocol_main_zip_local" || true
+curl -L "$protocol_branch_zip_url" -o "$protocol_branch_zip_local"
+unzip "$protocol_branch_zip_local" -d "$TMP_ZIP_DIR"
+rm "$protocol_branch_zip_local" || true
 
-ln -s "$(pwd)/node_modules" "$TMP_ZIP_DIR/protocol-main/node_modules"
+ln -s "$(pwd)/node_modules" "$TMP_ZIP_DIR/protocol-${BRANCH}/node_modules"
 
 # Run the `proto-compatibility-tool` and exclude the downloaded folder.
-echo "Checking the compatibility against $base_url"
-./node_modules/.bin/proto-compatibility-tool --recursive "$TMP_ZIP_DIR/protocol-main/proto" "proto"
+echo "Checking the compatibility against branch: ${BRANCH}"
+./node_modules/.bin/proto-compatibility-tool --recursive "$TMP_ZIP_DIR/protocol-${BRANCH}/proto" "proto"
 # ../proto-compatibility-tool/dist/bin.js --recursive "$TMP_ZIP_DIR/protocol-main" "."
 
 # rm -rf "$TMP_ZIP_DIR" || true