Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required dependencies are a bit much #23

Open
russelldc opened this issue Sep 3, 2021 · 7 comments
Open

Required dependencies are a bit much #23

russelldc opened this issue Sep 3, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@russelldc
Copy link

russelldc commented Sep 3, 2021

It'd be nice to install this without having to downgrade to torch 1.7.1 (as well as torchvision and some others).
It seems like this is being forced by the clip-by-openai package on pypi. Not sure I trust a random package like this (plus it's behind on commits by a few months), and I'd recommend installing directly from the official git repo.
I'm not sure if this can work inside a requirements.txt file, but this is what I usually do:
pip install git+https://github.com/openai/CLIP

I have an alternative in just doing a pip install memery --no-deps but then I'd have to gather all the missing dependencies manually.

@russelldc
Copy link
Author

From some quick googling/stackoverflowing, seems like it'd work fine in a requirements.txt file too:
git+https://github.com/openai/CLIP.git

@deepfates
Copy link
Owner

deepfates commented Sep 7, 2021 via email

@deepfates
Copy link
Owner

I see that the official CLIP repo recommends using Torch 1.7.1. Have you been using it fine with a different version @russelldc ?

@russelldc
Copy link
Author

russelldc commented Sep 7, 2021

I think that was changed since this commit (to be 1.7.1 and above, not just a hard requirement on 1.7.1):
openai/CLIP@db20393

@deepfates
Copy link
Owner

Okay, I have updated the dependencies. Found that PyPi doesn't allow install_requires to have dependencies on external repos, like "clip@git+https://github.com/openai/CLIP.git", but instead can use dependency_links which is built from dep_links in settings.ini. Hopefully it builds correctly from pip now, if anyone can give it a try and let me know that would be great

@deepfates deepfates added the bug Something isn't working label Sep 27, 2021
@deepfates
Copy link
Owner

Scratch that, it seems this doesn't work due to many reasons including the fact there's already something called clip in PyPi. Tried converting it to huggingface repo but they use a different forward pass system and it's a pain to translate.

I'm planning to switch to Jina soon anyway so maybe that will paper over all these issues

@wkrettek
Copy link
Contributor

Is a Jina refactor still on the table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants