Skip to content

Commit d50c006

Browse files
authored
Fix NullPointerException (#134)
* Fix NullPointerException https://github.com/natario1/Transcoder/issues/133 Fix NullPointerException with ClipDataSource(FilePathDataSource()) Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.media.MediaMetadataRetriever.extractMetadata(int)' on a null object reference at com.otaliastudios.transcoder.source.DefaultDataSource.getDurationUs(DefaultDataSource.java:276) at com.otaliastudios.transcoder.source.ClipDataSource.getSourceDurationUs(ClipDataSource.java:23) at com.otaliastudios.transcoder.source.ClipDataSource.(ClipDataSource.java:18) * Fix 0 duration audio output issue. https://github.com/natario1/Transcoder/issues/135
1 parent 9de11dc commit d50c006

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

lib/src/main/java/com/otaliastudios/transcoder/source/FilePathDataSource.java

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public void initialize() {
3838
} catch (IOException e) {
3939
throw new RuntimeException(e);
4040
}
41+
super.initialize();
4142
}
4243

4344
@Override
@@ -46,6 +47,7 @@ public void deinitialize() {
4647
// This means that we must also recreate the underlying source.
4748
mDescriptorSource.deinitialize();
4849
try { mStream.close(); } catch (IOException ignore) { }
50+
super.deinitialize();
4951
}
5052

5153
@Override

lib/src/main/java/com/otaliastudios/transcoder/source/TrimDataSource.java

+5
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@ public void initialize() {
6565
public long getDurationUs() {
6666
return trimDurationUs + extraDurationUs;
6767
}
68+
69+
@Override
70+
public long getPositionUs() {
71+
return super.getPositionUs() - trimStartUs;
72+
}
6873

6974
@Override
7075
public boolean canReadTrack(@NonNull TrackType type) {

0 commit comments

Comments
 (0)