chore: fix linting for ruff 0.12.0 (#1969)

* chore: fix linting for ruff 0.12.0

* fix mcp

* try fixing astra

Author: anakin87

integrations/astra/src/haystack_integrations/document_stores/astra/astra_client.py

@@ -144,6 +144,7 @@ def __init__(
 
     def query(
         self,
+        *,
         vector: Optional[List[float]] = None,
         query_filter: Optional[Dict[str, Union[str, float, int, bool, List, dict]]] = None,
         top_k: Optional[int] = None,
@@ -317,6 +318,7 @@ def update_document(self, document: Dict, id_key: str):
 
     def delete(
         self,
+        *,
         ids: Optional[List[str]] = None,
         delete_all: Optional[bool] = None,
         filters: Optional[Dict[str, Union[str, float, int, bool, List, dict]]] = None,

integrations/astra/src/haystack_integrations/document_stores/astra/document_store.py

@@ -392,7 +392,12 @@ def search(
 
         return result
 
-    def delete_documents(self, document_ids: Optional[List[str]] = None, delete_all: Optional[bool] = None) -> None:
+    def delete_documents(
+        self,
+        document_ids: Optional[List[str]] = None,
+        *,
+        delete_all: Optional[bool] = None,
+    ) -> None:
         """
         Deletes documents from the document store.
 

integrations/astra/tests/test_document_store.py

@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: 2023-present Anant Corporation <[email protected]>
 #
 # SPDX-License-Identifier: Apache-2.0
+import operator
 import os
 from typing import List
 from unittest import mock
@@ -78,8 +79,6 @@ def assert_documents_are_equal(self, received: List[Document], expected: List[Do
         This can happen for example when the Document Store sets a score to returned Documents.
         Since we can't know what the score will be, we can't compare the Documents reliably.
         """
-        import operator
-
         received.sort(key=operator.attrgetter("id"))
         expected.sort(key=operator.attrgetter("id"))
         assert received == expected

integrations/github/src/haystack_integrations/components/connectors/github/repo_forker.py

@@ -2,6 +2,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 import re
+import time
 from typing import Any, Dict, Optional
 
 import requests
@@ -274,8 +275,6 @@ def run(self, url: str) -> dict:
 
             # Wait for fork completion if requested
             if self.wait_for_completion:
-                import time
-
                 start_time = time.time()
 
                 while time.time() - start_time < self.max_wait_seconds:

integrations/google_genai/tests/test_chat_generator.py

@@ -9,7 +9,10 @@
 from haystack.tools import Tool, Toolset
 from haystack.utils.auth import Secret
 
-from haystack_integrations.components.generators.google_genai import GoogleGenAIChatGenerator
+from haystack_integrations.components.generators.google_genai.chat.chat_generator import (
+    GoogleGenAIChatGenerator,
+    _convert_message_to_google_genai_format,
+)
 
 
 @pytest.fixture
@@ -112,11 +115,6 @@ def test_convert_message_to_google_genai_format_complex(self):
         Test that the GoogleGenAIChatGenerator can convert a complex sequence of ChatMessages to Google GenAI format.
         In particular, we check that different tool results are handled properly in sequence.
         """
-        from haystack.dataclasses import ToolCall
-
-        from haystack_integrations.components.generators.google_genai.chat.chat_generator import (
-            _convert_message_to_google_genai_format,
-        )
 
         messages = [
             ChatMessage.from_system("You are good assistant"),

integrations/mcp/src/haystack_integrations/tools/mcp/mcp_tool.py

@@ -15,6 +15,7 @@
 from typing import Any, cast
 
 from anyio.streams.memory import MemoryObjectReceiveStream, MemoryObjectSendStream
+from exceptiongroup import ExceptionGroup
 from haystack import logging
 from haystack.core.serialization import generate_qualified_class_name, import_class_by_name
 from haystack.tools import Tool
@@ -749,8 +750,6 @@ def __init__(
             self.close()
 
             # Extract more detailed error information from TaskGroup/ExceptionGroup exceptions
-            from exceptiongroup import ExceptionGroup
-
             error_message = str(e)
             # Handle ExceptionGroup to extract more useful error messages
             if isinstance(e, ExceptionGroup):

integrations/opensearch/src/haystack_integrations/components/retrievers/opensearch/bm25_retriever.py

@@ -1,6 +1,9 @@
 # SPDX-FileCopyrightText: 2023-present deepset GmbH <[email protected]>
 #
 # SPDX-License-Identifier: Apache-2.0
+
+# ruff: noqa: FBT001  Boolean-typed positional argument in function definition
+
 from typing import Any, Dict, List, Optional, Union
 
 from haystack import component, default_from_dict, default_to_dict, logging

integrations/opensearch/src/haystack_integrations/components/retrievers/opensearch/embedding_retriever.py

@@ -2,6 +2,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
+# ruff: noqa: FBT001  Boolean-typed positional argument in function definition
+
 from typing import Any, Dict, List, Optional, Union
 
 from haystack import component, default_from_dict, default_to_dict, logging