Skip to content

tests requiring additional setup #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MetroCat69 opened this issue Apr 19, 2025 · 0 comments · May be fixed by #1663
Open

tests requiring additional setup #1659

MetroCat69 opened this issue Apr 19, 2025 · 0 comments · May be fixed by #1663
Labels
bug Something isn't working P3

Comments

@MetroCat69
Copy link

Describe the bug
Mongodb Atlas tests assume specific documents, collections and databases exists

so tests in test_embedding_retrieval automaticly fail

additionally test_embedding_retrieval and test_embedding_retrieval_async are searching for MONGO_CONNECTION_STRING_2 and till be skipped. I think this is a bug and we need to to replace MONGO_CONNECTION_STRING_2 with MONGO_CONNECTION_STRING

good news I am hard at working at a pr that will ensure this database, collection, documents will be created in an idempotent manner

To Reproduce
cd
git clone https://github.com/deepset-ai/haystack-core-integrations.git
cd haystack-core-integrations/integrations/mongodb_atlas
pip install hatch
export MONGO_CONNECTION_STRING = ""
hatch run test

@MetroCat69 MetroCat69 added the bug Something isn't working label Apr 19, 2025
@MetroCat69 MetroCat69 linked a pull request Apr 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants