Revert "fix: make from_dict of PyPDFToDocument more robust (#8422)"

This reverts commit 4e1d6f1.

Author: silvanocerza

haystack/components/converters/pypdf.py

@@ -108,10 +108,8 @@ def from_dict(cls, data):
         :returns:
             Deserialized component.
         """
-        # the converter default is `None`, check if it was defined before deserializing
-        if "converter" in data["init_parameters"]:
-            converter_class = deserialize_type(data["init_parameters"]["converter"]["type"])
-            data["init_parameters"]["converter"] = converter_class.from_dict(data["init_parameters"]["converter"])
+        converter_class = deserialize_type(data["init_parameters"]["converter"]["type"])
+        data["init_parameters"]["converter"] = converter_class.from_dict(data["init_parameters"]["converter"])
         return default_from_dict(cls, data)
 
     @component.output_types(documents=List[Document])

releasenotes/notes/pypdf-converter-robust-from-dict-35ebe6aaab944b19.yaml

@@ -40,12 +40,6 @@ def test_from_dict(self):
         assert isinstance(instance, PyPDFToDocument)
         assert isinstance(instance.converter, DefaultConverter)
 
-    def test_from_dict_no_converter(self):
-        data = {"type": "haystack.components.converters.pypdf.PyPDFToDocument", "init_parameters": {}}
-        instance = PyPDFToDocument.from_dict(data)
-        assert isinstance(instance, PyPDFToDocument)
-        assert isinstance(instance.converter, DefaultConverter)
-
     @pytest.mark.integration
     def test_run(self, test_files_path, pypdf_converter):
         """