🐞 with-lifecycle: fix a React warning caused by onReceiveProps (close #27)

deepsweet · deepsweet · commit dd1fc49838c8 · 2019-05-23T21:50:28.000+02:00
diff --git a/packages/with-lifecycle/src/index.js b/packages/with-lifecycle/src/index.js
@@ -26,7 +26,7 @@ export default (methodsArg) => (Target) => {
         }
 
         if (methods.onReceiveProps) {
-          this.state = props
+          this.state = { ...props }
 
           WithLifecycle.getDerivedStateFromProps = (nextProps, prevState) => {
             methods.onReceiveProps(prevState, nextProps)

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export default (methodsArg) => (Target) => {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`if (methods.onReceiveProps) {`
`29`		`- this.state = props`
	`29`	`+ this.state = { ...props }`
`30`	`30`
`31`	`31`	`WithLifecycle.getDerivedStateFromProps = (nextProps, prevState) => {`
`32`	`32`	`methods.onReceiveProps(prevState, nextProps)`