Skip to content

Commit 8fd8066

Browse files
committed
change requirement in setup.py and comment in BED reading
1 parent 55a5dc3 commit 8fd8066

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

hicexplorer/test/general/test_hicCorrectMatrix.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717

1818

1919
def are_files_equal(file1, file2, pDifference=1):
20-
equal = True
2120
with open(file1) as textfile1, open(file2) as textfile2:
2221
for x, y in zip(textfile1, textfile2):
2322
if x != y:
2423
count = sum(1 for a, b in zip(x, y) if a != b)
2524
if count > pDifference:
26-
equal = False
27-
break
28-
return equal
25+
return False
26+
return True
2927

3028

3129
def test_correct_matrix_ICE():

hicexplorer/utilities.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ def readTargetBed(pBedFile):
5656
try:
5757
chrom, start, end = _line[:4]
5858
except ValueError:
59+
# in case the BED is space seprated instead of tabs, split it by whitespaces
5960
_line = line.strip().split()
6061
chrom, start, end, gene = _line[:4]
6162
if gene not in present_genes[outer_matrix][inner_matrix]:

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def checkProgramIsInstalled(self, program, args, where_to_download,
116116
"tqdm >= 4.66",
117117
"hyperopt >= 0.2.7",
118118
"graphviz >= 0.20",
119-
"scikit-learn == 1.3.2",
119+
"scikit-learn >= 1.3,<1.4",
120120
"imbalanced-learn >= 0.11",
121121
"cleanlab >= 2.5"
122122
]

0 commit comments

Comments
 (0)