Skip to content

Behavior of already connected components during reassignment #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janniclas opened this issue Feb 18, 2019 · 0 comments
Open

Behavior of already connected components during reassignment #118

janniclas opened this issue Feb 18, 2019 · 0 comments

Comments

@janniclas
Copy link
Contributor

As @johannesduesing mentioned: "The only issue i can see is that you are currently able to re-assign a component to the same instance that it is already using, which is actually triggering a re-assignment call to the registry. I would expect to either hide the currently used dependency or just give the user a message that re-assignment is not needed because the desired dependency is already established.
Since i remember talking with @janniclas about this i'm not sure if that's intended behaviour for this PR, so i will still approve it in the current state."
The question is how we want to handle this.

  1. We could hide the connected components, but I thought it might be interesting for the admin to see the currently active connections during reconnect mode.
  2. We can display an extra notification when trying to reconnect two already connected components (maybe the reassignment is wanted in some cases).
@janniclas janniclas added this to the v0.9.5 milestone Feb 18, 2019
@janniclas janniclas modified the milestones: v0.9.5, v1.0.0 Mar 8, 2019
@janniclas janniclas removed this from the v1.0.0 milestone Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant