Following code style recommendations

Author: bhermann

src/backend/maven/Maven.ts

@@ -5,52 +5,36 @@ export class MavenAccess {
         const url = `/maven2/${groupId.replaceAll(".", "/")}/${artifactId
             }/${version}/${artifactId}-${version}.pom`;
 
-        const pom = await fetch(url)
+        return await fetch(url)
             .then((response) => response.text())
             .then((str) => {
                 const parser = new XMLParser();
                 return parser.parse(str).project;
             })
             .catch((reason) => console.error(reason));
-        return pom;
     }
 
-    async getArtifact(groupId: string, artifactId: string): Promise<any> {
-        const url = `/maven2/${groupId.replaceAll(".", "/")}/${artifactId}/`;
-
-        const artifacts = await fetch(url)
+    private async retrieveAndProcessDirectory(url: string): Promise<any> {
+        return await fetch(url)
             .then((response) => response.text())
             .then((text) => {
                 const parser = new DOMParser();
                 return Array.from(parser.parseFromString(text, "text/html")
-                                        .getElementById("contents")
-                                        ?.querySelectorAll("A")!)
-                                    .slice(1).map(a => a.textContent)
-                                             .filter(link => link?.endsWith("/"))
-                                             .map(link => link?.replace("/", ""));
+                    .getElementById("contents")
+                    ?.querySelectorAll("A")!)
+                    .slice(1).map(a => a.textContent)
+                    .filter(link => link?.endsWith("/"))
+                    .map(link => link?.replace("/", ""));
             })
             .catch((reason) => console.error(reason));
+    }
 
-        return artifacts;
+    async getArtifact(groupId: string, artifactId: string): Promise<any> {
+        return this.retrieveAndProcessDirectory(`/maven2/${groupId.replaceAll(".", "/")}/${artifactId}/`);
     }
 
     async getGroup(groupId: string): Promise<any> {
-        const url = `/maven2/${groupId.replaceAll(".", "/")}/`;
-
-        const group = await fetch(url)
-            .then((response) => response.text())
-            .then((text) => {
-                const parser = new DOMParser();
-                return Array.from(parser.parseFromString(text, "text/html")
-                                        .getElementById("contents")
-                                        ?.querySelectorAll("A")!)
-                                    .slice(1).map(a => a.textContent)
-                                             .filter(link => link?.endsWith("/"))
-                                             .map(link => link?.replace("/", ""));
-            })
-            .catch((reason) => console.error(reason));
-
-        return group;
+        return this.retrieveAndProcessDirectory(`/maven2/${groupId.replaceAll(".", "/")}/`);
     }
 
 

src/pages/MavenArtifactVersionView.vue

@@ -19,15 +19,15 @@
     <div v-else class="text-xs line-height-xs">
       <table class="text-left">
         <tr v-if="pom.name != null">
-          <th>Name</th>
+          <th scope="row">Name</th>
           <td>{{ pom.name }}</td>
         </tr>
         <tr v-if="pom.description != null">
-          <th>Description</th>
+          <th scope="row">Description</th>
           <td>{{ pom.description }}</td>
         </tr>
         <tr v-if="pom.parent != null">
-          <th>Parent</th>
+          <th scope="row">Parent</th>
           <td>
             <router-link
               :to="{
@@ -44,13 +44,13 @@
           </td>
         </tr>
         <tr v-if="pom.url != null">
-          <th>URL</th>
+          <th scope="row">URL</th>
           <td>
             <a :href="pom.url">{{ pom.url }}</a>
           </td>
         </tr>
         <tr v-if="pom.licenses != null && pom.licenses.license != null">
-          <th>License</th>
+          <th scope="row">License</th>
           <td>
             <a :href="pom.licenses.license.url">{{
               pom.licenses.license.name
@@ -71,8 +71,8 @@
           Dependencies
         </caption>
         <tr>
-          <th>Name</th>
-          <th>Scope</th>
+          <th scope="col">Name</th>
+          <th scope="col">Scope</th>
         </tr>
         <tr v-for="(d, index) in pom.dependencies.dependency" :key="index">
           <td>
@@ -98,8 +98,8 @@
           Properties
         </caption>
         <tr>
-          <th>Key</th>
-          <th>Value</th>
+          <th scope="col">Key</th>
+          <th scope="col">Value</th>
         </tr>
         <tr v-for="(value, key) in pom.properties" :key="key">
           <td>{{ key }}</td>

src/pages/MavenArtifactView.vue

@@ -9,10 +9,10 @@
 
     <div v-if="isLoading">Loading...</div>
     <div v-else class="text-xs line-height-xs">
-        <table class="text-left">
-        <caption class="text-left font-bold">
-          Versions
-        </caption>
+      <table class="text-left">
+        <tr>
+          <th scope="col">Versions</th>
+        </tr>
         <tr v-for="(v, index) in artifact" :key="index">
           <td>
             <router-link
@@ -24,7 +24,8 @@
                   version: v,
                 },
               }"
-              >{{ v }}</router-link>
+              >{{ v }}</router-link
+            >
           </td>
         </tr>
       </table>
@@ -64,11 +65,13 @@ export default defineComponent({
     }
 
     async function loadArtifact() {
-        if (groupId.value === undefined || 
-          artifactId.value === undefined) return;
-        isLoading.value = true;
-        artifact.value = await new MavenAccess().getArtifact(groupId.value, artifactId.value);
-        isLoading.value = false;
+      if (groupId.value === undefined || artifactId.value === undefined) return;
+      isLoading.value = true;
+      artifact.value = await new MavenAccess().getArtifact(
+        groupId.value,
+        artifactId.value
+      );
+      isLoading.value = false;
     }
 
     return { groupId, artifactId, isLoading, artifact };

src/pages/MavenGroupView.vue

@@ -1,26 +1,27 @@
 <template>
- <div>
+  <div>
     <h2 class="w-full text-delphi-red text-2xl font-semibold font-serif">
       {{ groupId }}
     </h2>
 
     <div v-if="isLoading">Loading...</div>
     <div v-else class="text-xs line-height-xs">
-        <table class="text-left">
-        <caption class="text-left font-bold">
-          Artifacts
-        </caption>
+      <table class="text-left">
+        <tr>
+          <th>Artifacts</th>
+        </tr>
         <tr v-for="(a, index) in group" :key="index">
           <td>
             <router-link
               :to="{
                 name: 'maven-ga',
                 params: {
                   groupId: groupId,
-                  artifactId: a
+                  artifactId: a,
                 },
               }"
-              >{{ a }}</router-link>
+              >{{ a }}</router-link
+            >
           </td>
         </tr>
       </table>
@@ -60,9 +61,7 @@ export default defineComponent({
     async function loadGroup() {
       if (groupId.value === undefined) return;
       isLoading.value = true;
-      group.value = await new MavenAccess().getGroup(
-        groupId.value
-      );
+      group.value = await new MavenAccess().getGroup(groupId.value);
       isLoading.value = false;
     }
 

vue.config.js

@@ -1,7 +1,4 @@
 module.exports = {
-    publicPath: process.env.NODE_ENV === 'production'
-        ? '/'
-        : '/',
     configureWebpack: {
         devServer: {
             headers: {