Put sign inside parenthesis when using negative degrees (KhronosGroup#540)

stevk · web-flow · commit e3dc2ef7558b · 2019-07-01T15:16:15.000-07:00
diff --git a/Source/ModelGroup_SkinB.cs b/Source/ModelGroup_SkinB.cs
@@ -13,7 +13,7 @@ protected static partial class Nodes
                 var colorInner = new Vector4(0.8f, 0.8f, 0.8f, 1.0f);
                 var colorOuter = new Vector4(0.0f, 0.0f, 1.0f, 1.0f);
 
-                Matrix4x4 rotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f);
+                Matrix4x4 rotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f);
                 var translationVectorJoint1 = new Vector3(0.0f, 0.0f, -0.6f);
                 var translationVectorJoint0 = new Vector3(0.0f, 0.0f, 0.3f);
                 Matrix4x4 matrixJoint1 = Matrix4x4.CreateTranslation(translationVectorJoint1);
diff --git a/Source/ModelGroup_SkinBuilder.cs b/Source/ModelGroup_SkinBuilder.cs
@@ -51,7 +51,7 @@ protected static partial class Nodes
                     }
                 }
 
-                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f);
+                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f);
                 Quaternion jointRotation = Quaternion.CreateFromRotationMatrix(Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-30.0f), 0.0f));
                 var translationVector = new Vector3(0.0f, 0.0f, vertexHeightOffset);
                 var translationVectorJoint0 = new Vector3(0.0f, startHeight, 0.0f);
diff --git a/Source/ModelGroup_SkinE.cs b/Source/ModelGroup_SkinE.cs
@@ -81,7 +81,7 @@ protected static partial class Nodes
 
             private static List<Runtime.Node> CreateJointsAndWeightsForCommonRoot(Runtime.Node nodePlane)
             {
-                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f);
+                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f);
                 Matrix4x4 jointRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-15.0f), 0.0f);
                 var translationVectorJoint3 = new Vector3(0.1875f, 0.0f, 0.25f);
                 var translationVectorJoint2 = new Vector3(-0.1875f, 0.0f, 0.25f);
@@ -271,7 +271,7 @@ protected static partial class Nodes
 
             private static List<Runtime.Node> CreateJointsAndWeightsForMultipleRoots(Runtime.Node nodePlane)
             {
-                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f);
+                Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f);
                 Matrix4x4 jointRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-15.0f), 0.0f);
                 var translationVectorJoint3 = new Vector3(0.0f, 0.25f, 0.0f);
                 var translationVectorJoint2 = new Vector3(0.0f, 0.0f, 0.25f);
diff --git a/Source/ModelGroups/Animation_Node.cs b/Source/ModelGroups/Animation_Node.cs
@@ -152,11 +152,11 @@ void SetLinearSamplerForRotation(List<Property> properties, Runtime.AnimationCha
                     },
                     new[]
                     {
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                     }
                 );
 
@@ -241,7 +241,7 @@ void CreateCubicSplineSamplerForRotation(List<Property> properties, Runtime.Anim
                         new Runtime.CubicSplineAnimationSampler<Quaternion>.Key
                         {
                             InTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f),
-                            Value = Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Value = Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                             OutTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f)
                         },
                         new Runtime.CubicSplineAnimationSampler<Quaternion>.Key
@@ -253,7 +253,7 @@ void CreateCubicSplineSamplerForRotation(List<Property> properties, Runtime.Anim
                         new Runtime.CubicSplineAnimationSampler<Quaternion>.Key
                         {
                             InTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f),
-                            Value = Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Value = Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),
                             OutTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f)
                         },
                         new Runtime.CubicSplineAnimationSampler<Quaternion>.Key
@@ -265,7 +265,7 @@ void CreateCubicSplineSamplerForRotation(List<Property> properties, Runtime.Anim
                         new Runtime.CubicSplineAnimationSampler<Quaternion>.Key
                         {
                             InTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f),
-                            Value = Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Value = Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                             OutTangent = new Quaternion(0.0f, 0.0f, 0.0f, 0.0f)
                         },
                     }
diff --git a/Source/ModelGroups/Animation_NodeMisc.cs b/Source/ModelGroups/Animation_NodeMisc.cs
@@ -122,11 +122,11 @@ void SetLinearSamplerForHorizontalRotation(Runtime.AnimationChannel channel)
                     },
                     new[]
                     {
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                     }
                 );
             }
@@ -145,11 +145,11 @@ void SetLinearSamplerForVerticalRotation(Runtime.AnimationChannel channel)
                     },
                     new[]
                     {
-                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
                     }
                 );
             }
@@ -219,11 +219,11 @@ void SetLinearSamplerForRotationThatStartsAboveZero(Runtime.AnimationChannel cha
                     },
                     new[]
                     {
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                     }
                 );
             }
diff --git a/Source/ModelGroups/Animation_SamplerType.cs b/Source/ModelGroups/Animation_SamplerType.cs
@@ -58,11 +58,11 @@ Model CreateModel(AnimationSampler.ComponentTypeEnum samplerOutputComponentType,
                         },
                         new[]
                         {
-                            Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                             Quaternion.Identity,
-                            Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),
                             Quaternion.Identity,
-                            Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),
+                            Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),
                         },
                         outputComponentType: samplerOutputComponentType
                     )
diff --git a/Source/ModelGroups/Animation_Skin.cs b/Source/ModelGroups/Animation_Skin.cs
@@ -99,7 +99,7 @@ Runtime.Animation CreateFoldingAnimation(Runtime.Node jointRootNode, List<Runtim
                 }
 
                 Runtime.Node nodeCheck = jointRootNode;
-                float pitchValue = -FloatMath.ToRadians(90);
+                float pitchValue = FloatMath.ToRadians(-90.0f);
                 var nodeList = new List<Runtime.Node>
                 {
                     jointRootNode,
diff --git a/Source/ModelGroups/Animation_SkinType.cs b/Source/ModelGroups/Animation_SkinType.cs
@@ -73,7 +73,7 @@ void AnimateWithRotation(List<Runtime.Animation> animations, List<Runtime.Node>
                     new[]
                     {
                         Quaternion.Identity,
-                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                        Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
                         Quaternion.Identity,
                     }
                 );
diff --git a/Source/ModelGroups/Instancing.cs b/Source/ModelGroups/Instancing.cs
@@ -70,20 +70,20 @@ Model CreateModel(Action<List<Property>, List<Runtime.Node>, List<Runtime.Animat
 
             var SamplerOutput = new[]
             {
-                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
                 Quaternion.Identity,
-                Quaternion.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f),
                 Quaternion.Identity,
-                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
             };
 
             var SamplerOutputReverse = new[]
             {
-                Quaternion.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f),
                 Quaternion.Identity,
-                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),
                 Quaternion.Identity,
-                Quaternion.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f),
+                Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f),
             };
 
             Runtime.Texture CreateTexture(Runtime.Image image)
diff --git a/Source/Property.cs b/Source/Property.cs
@@ -164,6 +164,6 @@ internal enum PropertyName
         SamplerOutputComponentType,
         LeftPrimitiveIndices,
         RightPrimitiveIndices,
-        Difference
+        Difference,
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ protected static partial class Nodes`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`- Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f);`
	`54`	`+ Matrix4x4 baseRotation = Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f);`
`55`	`55`	`Quaternion jointRotation = Quaternion.CreateFromRotationMatrix(Matrix4x4.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-30.0f), 0.0f));`
`56`	`56`	`var translationVector = new Vector3(0.0f, 0.0f, vertexHeightOffset);`
`57`	`57`	`var translationVectorJoint0 = new Vector3(0.0f, startHeight, 0.0f);`
Original file line number	Diff line number	Diff line change
`@@ -122,11 +122,11 @@ void SetLinearSamplerForHorizontalRotation(Runtime.AnimationChannel channel)`
`122`	`122`	`},`
`123`	`123`	`new[]`
`124`	`124`	`{`
`125`		`- Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`125`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),`
`126`	`126`	`Quaternion.Identity,`
`127`		`- Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`127`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),`
`128`	`128`	`Quaternion.Identity,`
`129`		`- Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`129`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),`
`130`	`130`	`}`
`131`	`131`	`);`
`132`	`132`	`}`
`@@ -145,11 +145,11 @@ void SetLinearSamplerForVerticalRotation(Runtime.AnimationChannel channel)`
`145`	`145`	`},`
`146`	`146`	`new[]`
`147`	`147`	`{`
`148`		`- Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),`
	`148`	`+ Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),`
`149`	`149`	`Quaternion.Identity,`
`150`		`- Quaternion.CreateFromYawPitchRoll(0.0f, -FloatMath.ToRadians(90), 0.0f),`
	`150`	`+ Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(-90.0f), 0.0f),`
`151`	`151`	`Quaternion.Identity,`
`152`		`- Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),`
	`152`	`+ Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),`
`153`	`153`	`}`
`154`	`154`	`);`
`155`	`155`	`}`
`@@ -219,11 +219,11 @@ void SetLinearSamplerForRotationThatStartsAboveZero(Runtime.AnimationChannel cha`
`219`	`219`	`},`
`220`	`220`	`new[]`
`221`	`221`	`{`
`222`		`- Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`222`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),`
`223`	`223`	`Quaternion.Identity,`
`224`		`- Quaternion.CreateFromYawPitchRoll(-FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`224`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(-90.0f), 0.0f, 0.0f),`
`225`	`225`	`Quaternion.Identity,`
`226`		`- Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90), 0.0f, 0.0f),`
	`226`	`+ Quaternion.CreateFromYawPitchRoll(FloatMath.ToRadians(90.0f), 0.0f, 0.0f),`
`227`	`227`	`}`
`228`	`228`	`);`
`229`	`229`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ Runtime.Animation CreateFoldingAnimation(Runtime.Node jointRootNode, List<Runtim`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`Runtime.Node nodeCheck = jointRootNode;`
`102`		`- float pitchValue = -FloatMath.ToRadians(90);`
	`102`	`+ float pitchValue = FloatMath.ToRadians(-90.0f);`
`103`	`103`	`var nodeList = new List<Runtime.Node>`
`104`	`104`	`{`
`105`	`105`	`jointRootNode,`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ void AnimateWithRotation(List<Runtime.Animation> animations, List<Runtime.Node>`
`73`	`73`	`new[]`
`74`	`74`	`{`
`75`	`75`	`Quaternion.Identity,`
`76`		`- Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90), 0.0f),`
	`76`	`+ Quaternion.CreateFromYawPitchRoll(0.0f, FloatMath.ToRadians(90.0f), 0.0f),`
`77`	`77`	`Quaternion.Identity,`
`78`	`78`	`}`
`79`	`79`	`);`
Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,6 @@ internal enum PropertyName`
`164`	`164`	`SamplerOutputComponentType,`
`165`	`165`	`LeftPrimitiveIndices,`
`166`	`166`	`RightPrimitiveIndices,`
`167`		`- Difference`
	`167`	`+ Difference,`
`168`	`168`	`}`
`169`	`169`	`}`