Add validation to check uniqeness of actions name and display name gr111 gr112

[mayyagoldman]

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-201484

Description

[github-actions]

Changelog(s) in markdown:

• Added new GR111 and GR112 validations. #5093

[github-actions]

Changelog(s) in markdown:

• Added new GR111 and GR112 validations. #5093

[RosenbergYehuda]

Nice job!
Approved, but please see my comments.

[RosenbergYehuda]

Why three attributes pointing to the same value??

[RosenbergYehuda]

I don't like this, now its a string, not a path...think about it.

[RosenbergYehuda]

please add a detailed docstring, similar to other functions

[RosenbergYehuda]

Here to, please add a dockstring

[RosenbergYehuda]

#empty??
Please add unit tests

[RosenbergYehuda]

both functions do the same thing, consider using 1 helper function, something like:

Suggested change

	"""
	def _validate_duplicate_agentix_action_field(
	tx: Transaction,
	file_paths: List[str],
	field_name: str
	) -> List[Tuple[str, List[str]]]:
	"""Generic validator for duplicate Agentix Action fields.
	Args:
	tx: The Neo4j transaction object.
	file_paths: List of file paths to filter results.
	field_name: The field to check for duplicates ('name' or 'display').
	Returns:
	List of tuples (action_id, list_of_duplicate_ids).
	"""
	query = f"""// Returns Agentix Actions with duplicate {field_name}
	MATCH (a:{ContentType.AGENTIX_ACTION}), (b:{ContentType.AGENTIX_ACTION})
	WHERE a.{field_name} = b.{field_name}
	"""
	if file_paths:
	query += f"AND a.path in {file_paths}"
	query += """
	AND elementId(a) <> elementId(b)
	RETURN a.object_id AS a_object_id, collect(b.object_id) AS b_object_ids
	"""
	return [
	(item.get("a_object_id"), item.get("b_object_ids"))
	for item in run_query(tx, query)
	]
	def validate_multiple_agentix_actions_with_same_display_name(
	tx: Transaction, file_paths: List[str]
	) -> List[Tuple[str, List[str]]]:
	"""Query graph to return Agentix Actions with duplicate display names."""
	return _validate_duplicate_agentix_action_field(tx, file_paths, "display")
	def validate_multiple_agentix_actions_with_same_name(
	tx: Transaction, file_paths: List[str]
	) -> List[Tuple[str, List[str]]]:
	"""Query graph to return Agentix Actions with duplicate names."""
	return _validate_duplicate_agentix_action_field(tx, file_paths, "name")

[RosenbergYehuda]

i'm not sure what you you are doing here, it's for unit tests so i'm not concern, just check if it can be done better.