From e146fe3190ebb5e4d125274fc4e450e8ccbd078f Mon Sep 17 00:00:00 2001
From: vickash <vickashmahabir@gmail.com>
Date: Mon, 23 Sep 2024 16:49:24 -0400
Subject: [PATCH] Fully remove #before_initialize and #after_initialize

---
 lib/denko/behaviors/component.rb       |  4 ----
 test/digital_io/rotary_encoder_test.rb | 14 ++++++--------
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/lib/denko/behaviors/component.rb b/lib/denko/behaviors/component.rb
index eedf549..4badfa6 100644
--- a/lib/denko/behaviors/component.rb
+++ b/lib/denko/behaviors/component.rb
@@ -84,13 +84,9 @@ def unregister
       # Behaviors::Component only requires a board.
       # Include modules from Setup or override this to use pins.
       #
-      def before_initialize(options={}); end
       def convert_pins(options={});      end
       def initialize_pins(options={});   end
       alias :initialize_pin :initialize_pins
-
-      # Override in components. Call super when inheriting or mixing in.
-      def after_initialize(options={}); end
     end
   end
 end
diff --git a/test/digital_io/rotary_encoder_test.rb b/test/digital_io/rotary_encoder_test.rb
index 6450af3..21bb0b0 100644
--- a/test/digital_io/rotary_encoder_test.rb
+++ b/test/digital_io/rotary_encoder_test.rb
@@ -30,36 +30,34 @@ def test_resets_on_initialize
 
   def test_sets_debounce_time_for_both_pins
     a_mock = Minitest::Mock.new.expect(:call, nil, [1])
-    a_mock.expect(:call, nil, [2])
     b_mock = Minitest::Mock.new.expect(:call, nil, [1])
-    b_mock.expect(:call, nil, [2])
 
     part.a.stub(:debounce_time=, a_mock) do
       part.b.stub(:debounce_time=, b_mock) do
         part.send(:run_after_initialize_cbs)
-        part.send(:after_initialize, debounce_time: 2)
       end
     end
+    a_mock.verify
+    b_mock.verify
   end
 
   def test_calls_listen_on_both_pins_with_given_divider
     a_mock = Minitest::Mock.new.expect(:call, nil, [1])
-    a_mock.expect(:call, nil, [2])
     b_mock = Minitest::Mock.new.expect(:call, nil, [1])
-    b_mock.expect(:call, nil, [2])
 
     part.a.stub(:listen, a_mock) do
       part.b.stub(:listen, b_mock) do
-        part.send(:after_initialize)
-        part.send(:after_initialize, divider: 2)
+        part.send(:run_after_initialize_cbs)
       end
     end
+    a_mock.verify
+    b_mock.verify
   end
 
   def test_observes_on_initialize
     mock = Minitest::Mock.new.expect(:call, nil)
     part.stub(:observe_pins, mock) do
-      part.send(:after_initialize)
+      part.send(:run_after_initialize_cbs)
     end
   end