fix import_sync unhandled rejection

Author: devsnek

Cargo.lock

@@ -28,7 +28,7 @@ deno_error = { version = "0.7.0", features = ["serde_json", "serde", "url", "tok
 deno_ops = { version = "0.262.0", path = "./ops" }
 deno_unsync = "0.4.2"
 serde_v8 = { version = "0.295.0", path = "./serde_v8" }
-v8 = { version = "145.0.0", default-features = false }
+v8 = { version = "146.1.0", default-features = false }
 
 anyhow = "1"
 bencher = "0.1"

Cargo.toml

@@ -1543,10 +1543,22 @@ impl ModuleMap {
     let promise = v8::Local::<v8::Promise>::try_from(value)
       .expect("Expected to get promise as module evaluation result");
 
+    promise.mark_as_handled();
+
     match promise.state() {
       PromiseState::Fulfilled => Ok(()),
       PromiseState::Rejected => {
         let err = promise.result(tc_scope);
+
+        let exception_state = JsRealm::exception_state_from_scope(tc_scope);
+        // TODO: remove after crrev.com/c/7595271
+        exception_state.track_promise_rejection(
+          tc_scope,
+          promise,
+          v8::PromiseRejectEvent::PromiseHandlerAddedAfterReject,
+          None,
+        );
+
         Err(
           CoreErrorKind::Js(JsError::from_v8_exception(tc_scope, err))
             .into_box(),

core/modules/map.rs

@@ -232,7 +232,7 @@ pub fn op_print(
   Ok(())
 }
 
-pub struct WasmStreamingResource(pub(crate) RefCell<v8::WasmStreaming>);
+pub struct WasmStreamingResource(pub(crate) RefCell<v8::WasmStreaming<false>>);
 
 impl Resource for WasmStreamingResource {
   fn close(self: Rc<Self>) {
@@ -623,7 +623,20 @@ fn wrap_module<'s, 'i>(
 
   wrapper_module.instantiate_module(scope, resolve_callback)?;
 
-  wrapper_module.evaluate(scope)?;
+  let result = wrapper_module.evaluate(scope)?;
+  if let Ok(promise) = result.try_cast::<v8::Promise>() {
+    promise.mark_as_handled();
+    if promise.state() == v8::PromiseState::Rejected {
+      let exception_state = JsRealm::exception_state_from_scope(scope);
+      // TODO: remove after crrev.com/c/7595271
+      exception_state.track_promise_rejection(
+        scope,
+        promise,
+        v8::PromiseRejectEvent::PromiseHandlerAddedAfterReject,
+        None,
+      );
+    }
+  }
 
   Some(wrapper_module)
 }

core/ops_builtin.rs

@@ -1435,7 +1435,7 @@ async fn global_template_middleware() {
   ) -> v8::Intercepted {
     CALLS.lock().push("descriptor".to_string());
 
-    v8::Intercepted::No
+    v8::Intercepted::kNo
   }
 
   pub fn setter<'s>(
@@ -1446,7 +1446,7 @@ async fn global_template_middleware() {
     _rv: v8::ReturnValue<()>,
   ) -> v8::Intercepted {
     CALLS.lock().push("setter".to_string());
-    v8::Intercepted::No
+    v8::Intercepted::kNo
   }
 
   fn definer<'s>(
@@ -1457,7 +1457,7 @@ async fn global_template_middleware() {
     _rv: v8::ReturnValue<()>,
   ) -> v8::Intercepted {
     CALLS.lock().push("definer".to_string());
-    v8::Intercepted::No
+    v8::Intercepted::kNo
   }
 
   pub fn gt_middleware<'s>(

core/runtime/tests/misc.rs

@@ -250,11 +250,11 @@ impl V8FastCallType {
       V8FastCallType::Bool => quote!(CType::Bool.as_info()),
       V8FastCallType::U32 => quote!(v8::fast_api::CTypeInfo::new(
         CType::Uint32,
-        v8::fast_api::Flags::Clamp
+        v8::fast_api::Flags::empty(),
       )),
       V8FastCallType::I32 => quote!(v8::fast_api::CTypeInfo::new(
         CType::Int32,
-        v8::fast_api::Flags::Clamp
+        v8::fast_api::Flags::empty(),
       )),
       V8FastCallType::U64 => quote!(CType::Uint64.as_info()),
       V8FastCallType::I64 => quote!(CType::Int64.as_info()),

ops/op2/dispatch_fast.rs

@@ -0,0 +1,21 @@
+// Copyright 2018-2025 the Deno authors. MIT license.
+
+import { assertThrows } from "checkin:testing";
+const { op_import_sync, op_path_to_url } = Deno.core.ops;
+
+globalThis.onunhandledrejection = (...args) => {
+  console.error("unexpected call", args);
+};
+globalThis.onrejectionhandled = (...args) => {
+  console.error("unexpected call", args);
+};
+
+assertThrows(
+  () => {
+    op_import_sync(
+      op_path_to_url("./integration/import_sync_throw/module.mjs"),
+    );
+  },
+  Error,
+  "this is a test",
+);

testing/integration/import_sync_throw/import_sync_throw.out

@@ -0,0 +1 @@
+throw new Error("this is a test");

testing/integration/import_sync_throw/import_sync_throw.ts

@@ -77,6 +77,7 @@ integration_test!(
   error_get_script_name_or_source_url,
   import_sync,
   import_sync_existing,
+  import_sync_throw,
   main_module_handler,
   module_types,
   pending_unref_op_tla,