buster: delete broken udev rules #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The udev rule 60-block.rules tries to call '/sbin/initblockdev', but that file only exists in the initrd, but not in the main rootfs, so any attempts will just fail. So drop the udev rule trying to call it. Silences errors at boot like: > Sep 15 09:18:55 localhost systemd-udevd[574]: Process '/sbin/initblockdev mtdblock0 add' failed with exit code 1. > Sep 15 09:18:55 localhost systemd-udevd[557]: Process '/sbin/initblockdev mtdblock1 add' failed with exit code 1. > Sep 15 09:18:55 localhost systemd-udevd[567]: Process '/sbin/initblockdev mtdblock2 add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[555]: Process '/sbin/initblockdev sda add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[555]: Process '/sbin/initblockdev sda1 add' failed with exit code 1. > ... Signed-off-by: Jonas Gorski <[email protected]>
The udev rule 60-net.rules tries to call '/sbin/initnetdev', but that file is found at a different location, at '/usr/bin/initnetdev', so the call always fails. Since the only purpose of initnetdev is to rename network devices based on the platform configuration, the initial management port renaming is already done by the initrd, and for any subsequent port devices we have an extra rule, drop the udev rule instead of trying to fix it. Silences errors at boot like: > Sep 15 09:18:55 localhost systemd-udevd[573]: Process '/sbin/initnetdev ma1 add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[553]: Process '/sbin/initnetdev eth1 add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[586]: Process '/sbin/initnetdev eth11 add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[594]: Process '/sbin/initnetdev eth33 add' failed with exit code 1. > Sep 15 09:18:56 localhost systemd-udevd[596]: Process '/sbin/initnetdev eth19 add' failed with exit code 1. > ... Signed-off-by: Jonas Gorski <[email protected]>
paulmenzel
approved these changes
Sep 18, 2023
taraschornyiplv
approved these changes
Sep 20, 2023
taraschornyiplv
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The udev rules 60-block.rules and 60-net.rules try to call binaries that do not exist at these paths in the main rootfs, so always fail. Since neither of them do anything useful outside of the initrd (where udev isn't used), drop the udev rules trying to call them instead of trying to fix them up.
Silences errors like: